Make Cmdline modules case insensitive #2223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Cmdline users had to type the exact capitalization of each mod identifier in the
install
,remove
, andupgrade
commands. This pull request adds a lookup step to convert "incorrectly"-capitalized identifiers to their correct capitalization, based on what is indexed in the registry. This allows users to type any capitalization they like as long as the letters are all the same.Before:
After:
The
identifier=version
format code is refactored slightly to create a reusable/shared compiled Regex object, then used inCkanModule.FromIDandVersion
as well as the new lookup code.Fixes #889.