Provide fresh auto updater in releases #2212
Conversation
ed85977 to
cea39d0
Compare
Core/Net/AutoUpdate.cs
Outdated
| fetchedCkanUrl = RetrieveUrl(response, 0); | ||
| // Check whether the release includes the auto updater | ||
| if (response.assets.Count >= 2) { | ||
| // Second asset is AutoUpdater.exe |
There was a problem hiding this comment.
The CKAN.app is now the second asset, and aren't we going to add in a .deb as well? Can we use a regex on the assets to find the correct one, rather than hard-code the position?
There was a problem hiding this comment.
Yup, this needs to be updated every time we add to that list (which hopefully won't be too many more times). It was 1 before the mac PR got merged, and I'll be incrementing it again now that the deb project is in. Luckily GitHub helpfully notices that these PRs all conflict with one another, which ensures that we don't merge without reconciling them.
Though yeah, you're right, it should examine the assets rather than hard coding an index. Once this client version is out in the wild, it would be impossible to rearrange things...
- Add AutoUpdater.exe to release file list in travis-ci - Look for auto updater file in main release - Update tests now that releases may contain multiple files
cea39d0 to
19328d4
Compare
|
After the latest commit, it now checks the URLs to find the auto updater rather than assuming a particular index. |
This pull request replaces #2204, which was closed because its approach wasn't appropriate. See that PR for details of the problem being solved.
New approach:
This change assumes that the list of assets in the release will be in the same order as they are in the
.travis.ymlfile. I believe this would be the case because it's an array rather than a dictionary, and the easiest way for Travis to implement it would be a simpleforeachloop, but I was not able to find documentation or a concrete example to confirm this.We should mention in the next release notes that users do not need to download AutoUpdater.exe manually.
Partially fixes #2140. The error will still occur when updating to this release, because the old clients will still use the 2-year-old auto updater exe, but updating from this release to the next release will use the latest auto update code. If we publish one last manual release to https://github.com/KSP-CKAN/CKAN-autoupdate/releases , then the current clients will update properly as well.