Change Icon on FilterTool Button to something filter-y #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to help review, but there are conflicts now. Can you rebase? |
09e315a to
59eef26
Compare
|
Rebased |
|
Can the old old search.png file be removed? I don't think it's being used anymore. |
|
Good point |
|
I'm tempted to leave it in, since it may come in useful in the future, and it's only 1493 bytes. |
|
I suppose it's not important, and the new icon definitely works fine. I'll take a stab at following the full merge process, including change log updates... |
|
We've been putting "Merge # Blah blah blah" as the comment on the Merge commit, to make the merge commits stand out in the history. Other than that, <3<3<3!!!! |
|
That's a good idea; I've added it to the wiki's merging notes to help me remember for next time. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the magnifying glass with something better (I refuse to accept the funnel = filter idea)
Closes #2009