Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand .gitignore to handle packages in subdirectories and build output #2116

Merged
merged 1 commit into from
Oct 7, 2017
Merged

Expand .gitignore to handle packages in subdirectories and build output #2116

merged 1 commit into from
Oct 7, 2017

Conversation

ayan4m1
Copy link
Contributor

@ayan4m1 ayan4m1 commented Sep 27, 2017

No description provided.

@ayan4m1 ayan4m1 added Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...) Pull request labels Sep 28, 2017
@politas
Copy link
Member

politas commented Oct 4, 2017

doesn't ignoring /_build/ also ignore all subdirectories? All packages and build output should be in there.

@ayan4m1
Copy link
Contributor Author

ayan4m1 commented Oct 5, 2017

It does, binaries/release materials should generally not be committed to version control. My change to the .gitignore does not touch the already-existing _build rule.

@politas politas merged commit 56f2c53 into KSP-CKAN:master Oct 7, 2017
politas added a commit that referenced this pull request Oct 7, 2017
@politas
Merge #2116 Expand .gitignore to handle packages in subdirectories an…
bcf87c2 
…d build output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@politas politas

Labels
Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayan4m1 @politas