Download default metadata in .tar.gz rather than .zip format #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point, we gained the ability to read `.tar.gz` files, but the client continued to use `.zip` to download metadata. This change flips us to use tarballs, which are *an order of magnitude smaller* than the .zip files. This can make a big difference, especially on slow connections. This change will affect both new users, and existing users if and only if they're using the default repository settings.
| // custom-added by our user. | ||
|
|
||
| Repository default_repo; | ||
| var OldDefaultRepo = new Uri("https://github.com/KSP-CKAN/CKAN-meta/archive/master.zip"); |
There was a problem hiding this comment.
Local variables are typically always camelCase, so defaultRepo and oldDefaultRepo.
|
@dbent : Thank you so much! Adjusted code to contain more camels. :) |
dbent
added a commit
that referenced
this pull request
Jul 31, 2015
Download default metadata in .tar.gz rather than .zip format
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, we gained the ability to read
.tar.gzfiles, but the client continued to use.zipto download metadata. This change flips us to use tarballs, which are an order of magnitude smaller than the .zip files. This can make a big difference, especially on slow connections.This change will affect both new users, and existing users if and only if they're using the default repository settings.