Fix for uncaught Inconsistent Kraken. #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ran with procede_with_inconsistencies the exception should never have been thrown. See KSP-CKAN#1175 (comment) for details on reproduction steps. This fix has issues with poor communication to the user regarding why it conflicts but it is better than crashing.
|
Still trying to reproduce the original bug, I suspect all our other patches have been very effective at shielding it. |
|
Have had @BasharMilesTeg test and confirm this helps, so I'm merging away. (Apparently BMT can get another exception out of the code, but I don't believe that's a regression at all.) |
pjf
added a commit
that referenced
this pull request
Jun 30, 2015
* RichardLake/RelResVersionFix2: Fix for uncaught Inconsistent Kraken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ran with procede_with_inconsistencies the exception should never have been thrown. See #1175 (comment) for details on reproduction steps.
This fix has issues with poor communication to the user regarding why it conflicts but it is better than crashing.