Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKAN bricks with InconsistentKraken if manually installed MM is removed #885

Closed
netkan-bot opened this issue May 21, 2015 · 10 comments
Closed
Labels
Bug Something is not working as intended Cmdline Issues affecting the command line GUI Issues affecting the interactive GUI

Comments

@netkan-bot
Copy link
Member

Issue by Ippo343
Saturday Dec 27, 2014 at 12:20 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT
Originally opened as https://github.com/KSP-CKAN/CKAN-support/issues/21


From @Ippo343 on December 9, 2014 17:6

So, I found a neat way to brick my ckan :)

  • Install ModuleManager manually
  • Install more modules through ckan: ckan will recognize MM as "auto detected"
  • Manually remove MM
  • try to rescan -> Kraken!

ckan repair registry did not help. I think that at the very least both the CLI and the GUI should catch it and avoid crashing hard.

Copied from original issue: #539

@netkan-bot netkan-bot added Bug Something is not working as intended GUI Issues affecting the interactive GUI Cmdline Issues affecting the command line labels May 21, 2015
@netkan-bot
Copy link
Member Author

Comment by Ippo343
Saturday Dec 27, 2014 at 12:20 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT


From @pjf on December 10, 2014 5:9

@Ippo343 : Out of curiosity, what happens if you try to install ModuleManager via the CKAN? It should work, because at the end of the operation we're back in a consistent state.

What should our expected behaviour be here?

@netkan-bot
Copy link
Member Author

Comment by Ippo343
Saturday Dec 27, 2014 at 12:20 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT


From @Postremus on December 10, 2014 5:49

You can't install ModuleManager via they guy once you had it manuelly
removed. You simply can't select MM.

2014-12-10 6:09 GMT+01:00 Paul Fenwick notifications@github.com:

@Ippo343 https://github.com/Ippo343 : Out of curiosity, what happens if
you try to install ModuleManager via the CKAN? It should work, because
at the end of the operation we're back in a consistent state.

What should our expected behaviour be here?


Reply to this email directly or view it on GitHub
#539 (comment).

@netkan-bot
Copy link
Member Author

Comment by Ippo343
Saturday Dec 27, 2014 at 12:20 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT


From @DuoDex on December 18, 2014 23:35

I had this too.

@netkan-bot
Copy link
Member Author

Comment by Ippo343
Saturday Dec 27, 2014 at 12:20 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT


From @henrybauer on December 23, 2014 18:19

I just got this in 1.3.7, in the same way. I wanted to switch to the CKAN version of ModuleManager, so manually deleted the modulemanager DLL. Run ckan scan (or the GUI "refresh" button) and it crashes. Put the modulemanager DLL back in, and it runs fine.. but now since it's autodetected, I can't install the CKAN version of ModuleManager.

C:\Program Files (x86)\Steam\SteamApps\common\Kerbal Space Program>ckan scan

Unhandled Exception: CKAN.InconsistentKraken: Exception of type 'CKAN.Inconsiste
ntKraken' was thrown.
at CKAN.SanityChecker.EnforceConsistency(IEnumerable1 modules, IEnumerable1
dlls)
at CKAN.RegistryManager.Save()
at CKAN.KSP.ScanGameData()
at CKAN.CmdLine.MainClass.Scan(KSP current_instance)
at CKAN.CmdLine.MainClass.Main(String[] args)

C:\Program Files (x86)\Steam\SteamApps\common\Kerbal Space Program>

@pjf
Copy link
Member

pjf commented May 22, 2015

D'oh, I meant to ask what happens if you try to install it via the cmdline. We're seeing either two things here:

  1. The core is correctly letting us go from an inconsistent state (where dependencies aren't satisfied) to a consistent one, but the GUI is crashing before we can do this.
  2. The core is crashing when it finds we're inconsistent to begin with.

This is hopefully the first error (meaning it can at least be worked around by using the command line) and hopefully not the second.

In any case, we should be getting rid of autodetected mods sooner rather than later. They provide very little value now that the CKAN is mature, and continue to provide us with lots and lots of pain.

@ctbram
Copy link

ctbram commented Apr 24, 2016

So I cannot manually remove manually added mods without bricking my entire ckan installation!!!! That is ridiculous and as far as I am concerned makes CKAN useless garbage!

I just removed precisenode and procedural fairings as they were just added to ckan and now my entire 50+ mod installation is f'ing bricked! GG!@

@politas
Copy link
Member

politas commented Apr 24, 2016

If you manually uninstall a mod that many packages are dependent upon, yes, it will break CKAN. Not your KSP, though. All you need to do is reinstall the mod manually.

It is not ideal to start using CKAN after you have already installed mods, and CKAN is not designed to handle manually installed mods. Its purpose is to get you to the point where you don't have to install mods manually. Your KSP should be fine if you reinstall those mods manually. To fix the problem, find the mods that are dependent on the ones you deleted, uninstall them, then manually delete your manually installed dependencies, then you should be able to go into CKAN and install everything back.

@ctbram
Copy link

ctbram commented Apr 24, 2016

thx. I will track down the dependencies.

The problem not manually adding mods if one uses CKAN is that mods are
constantly being added to the CKAN repository. For instance, Proc
fairings was not in CKAN a couple days ago. I think it is not really
reasonable to ask users to forgo using all mods until they are added to the
CKAN repository.

But now that I know what is causing the crash I can fix it.

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon
Virus-free.
www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link
<#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Sun, Apr 24, 2016 at 3:03 AM, Myk Dowling notifications@github.com
wrote:

If you manually uninstall a mod that many packages are dependent upon,
yes, it will break CKAN. Not your KSP, though. All you need to do is
reinstall the mod manually.

It is not ideal to start using CKAN after you have already installed mods,
and CKAN is not designed to handle manually installed mods. Its purpose is
to get you to the point where you don't have to install mods manually. Your
KSP should be fine if you reinstall those mods manually. To fix the
problem, find the mods that are dependent on the ones you deleted,
uninstall them, then manually delete your manually installed dependencies,
then you should be able to go into CKAN and install everything back.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#885 (comment)

@politas
Copy link
Member

politas commented Apr 24, 2016

If you see a mod that you know is released for a specific KSP version, and CKAN doesn't have it, post an issue about that, and we'll fix it.

@HebaruSan
Copy link
Member

As of #2674 we are able to install a missing Module Manager dependency. I think this is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Cmdline Issues affecting the command line GUI Issues affecting the interactive GUI
Projects
None yet
Development

No branches or pull requests

5 participants