A provided mod can't satisfy a suggestion

[Postremus]

Steps to reproduce:

1. Install ProceduralFairing. It suggest PFTextures.
2. "ProceduralFairings-ForEverything" should be suggested, but it isn't. It provides PFTextures.

Tested on ckan 1.10.0, ksp 1.0.4. Only tested the gui so far.

Reported by Felger on IRC

[mheguy]

Same behaviour in Win7-64bit command-line.

[Postremus]

Further investigation showed, that the gui calls registry.LatestAvailable(..) instead of registry.LatestAvailableWithProvides(..)

[HebaruSan]

This is included in the text UI in #2177. Just need to catch ModuleNotFoundKraken here and call LatestAvailableWithProvides:

CKAN/GUI/MainInstall.cs

Lines 183 to 199 in 6aac488

	// if the mod is available for the current KSP version _and_
	// the mod is not installed _and_
	// the mod is not already in the install list
	if (registry.LatestAvailable(mod.name, CurrentInstance.VersionCriteria()) != null
	&& !registry.IsInstalled(mod.name)
	&& !toInstall.Any(m => m.identifier == mod.name))
	{
	// add it to the list of chooseAble mods we display to the user
	if (!chooseAble.ContainsKey(mod.name))
	{
	chooseAble.Add(mod.name, new List<string>());
	}
	chooseAble[mod.name].Add(identifier);
	}
	}
	// XXX - Don't ignore all krakens! Those things are important!
	catch (Kraken)

[politas]

I don't think that commit made it into #2177

[HebaruSan]

Sorry, what I meant was that ConsoleUI allows "provides" mods to satisfy suggestions. #2177 indeed did not modify GUI.

[politas]

I can't find that commit "Satisfy suggestions w/ provides as per #1234" in the master tree, and the code as it is doesn't include that change. I think you maybe added it to your branch after it was merged, or didn't push the commit through to GitHub in time?

[HebaruSan]

This is the code that does it. If LatestAvailable doesn't find anything, ConsoleUI falls back to LatestAvailableWithProvides.

CKAN/ConsoleUI/DependencyScreen.cs

Lines 156 to 171 in 2692e03

	} catch (ModuleNotFoundKraken) {
	// LatestAvailable throws if you recommend a "provides" name,
	// so ask the registry again for provides-based choices
	List<CkanModule> opts = registry.LatestAvailableWithProvides(
	dependency.name,
	manager.CurrentInstance.VersionCriteria(),
	dependency
	);
	foreach (CkanModule provider in opts) {
	if (!registry.IsInstalled(provider.identifier)
	&& !alreadyInstalling.Contains(provider.identifier)) {
	// Default to not installing because these probably conflict with each other
	AddDep(provider.identifier, false, identifier);
	}
	}

I think the commit you're referencing was an error and had to be removed; if I recall correctly, it treated the mod being installed as the ID to look up for provides, whereas we actually want to look at its suggests/recommends.

[politas]

Ah, now I understand! Thanks for persisting in clearing up my confusion.

[HebaruSan]

Heh, thanks for persisting in asking; I was just as confused until I remembered the story with that commit.