Leave out children already shown in ancestor node

KSP-CKAN · Jan 17, 2018 · ee6d4cd · ee6d4cd
1 parent 26ff29b
commit ee6d4cd
Showing 1 changed file with 20 additions and 0 deletions.
diff --git a/GUI/MainModInfo.cs b/GUI/MainModInfo.cs
@@ -184,6 +184,22 @@ private void BeforeExpand(object sender, TreeViewCancelEventArgs args)
             Cursor.Current = prevCur;
         }
 
+        private bool ImMyOwnGrandpa(TreeNode node)
+        {
+            CkanModule module = node.Tag as CkanModule;
+            if (module != null)
+            {
+                for (TreeNode other = node.Parent; other != null; other = other.Parent)
+                {
+                    if (module == other.Tag)
+                    {
+                        return true;
+                    }
+                }
+            }
+            return false;
+        }
+
         private void UpdateModDependencyGraph(CkanModule module)
         {
             ModInfoTabControl.Tag = module ?? ModInfoTabControl.Tag;
@@ -224,6 +240,10 @@ private void _UpdateModDependencyGraph()
 
         private void AddChildren(IRegistryQuerier registry, TreeNode node)
         {
+            // Skip children of nodes from circular dependencies
+            if (ImMyOwnGrandpa(node))
+                return;
+
             // Load one layer of grandchildren on demand
             CkanModule module = node.Tag as CkanModule;
             // Tag is null for non-indexed nodes