Show dependencies of upgrading mods in change set

KSP-CKAN · Apr 10, 2022 · a45bfe6 · a45bfe6
1 parent 04484a6
commit a45bfe6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/GUI/Controls/Changeset.cs b/GUI/Controls/Changeset.cs
@@ -20,19 +20,17 @@ public void LoadChangeset(List<ModChange> changes, List<ModuleLabel> AlertLabels
             ChangesListView.Items.Clear();
             if (changes != null)
             {
-                // We're going to split our change-set into two parts: updated/removed mods,
-                // and everything else (which right now is replacing and installing mods, but we may have
+                // We're going to split our change-set into two parts: removed mods,
+                // and everything else (right now, replacing, upgrading, and installing mods, but we may have
                 // other types in the future).
 
                 sortedChangeSet.Clear();
                 sortedChangeSet.AddRange(changes.Where(change => change.ChangeType == GUIModChangeType.Remove));
-                sortedChangeSet.AddRange(changes.Where(change => change.ChangeType == GUIModChangeType.Update));
 
                 // Now make our list more human-friendly (dependencies for a mod are listed directly
                 // after it.)
                 CreateSortedModList(changes
-                    .Where(change => change.ChangeType != GUIModChangeType.Remove
-                                  && change.ChangeType != GUIModChangeType.Update)
+                    .Where(change => change.ChangeType != GUIModChangeType.Remove)
                     .ToList());
 
                 ChangesListView.Items.AddRange(sortedChangeSet

diff --git a/GUI/Model/ModList.cs b/GUI/Model/ModList.cs
@@ -130,6 +130,8 @@ public IEnumerable<ModChange> ComputeChangeSetFromModList(
                     case GUIModChangeType.None:
                         break;
                     case GUIModChangeType.Update:
+                        modules_to_install.Add((change as ModUpgrade)?.targetMod ?? change.Mod);
+                        break;
                     case GUIModChangeType.Install:
                         modules_to_install.Add(change.Mod);
                         break;