Log errors instead of PRs for OOO mods on GitHub

KSP-CKAN · Aug 11, 2022 · a2dff98 · a2dff98
1 parent 4296d75
commit a2dff98
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/Netkan/Transformers/EpochTransformer.cs b/Netkan/Transformers/EpochTransformer.cs
@@ -63,9 +63,16 @@ public IEnumerable<Metadata> Transform(Metadata metadata, TransformOptions opts)
                 if (!opts.HighestVersion.EpochEquals(currentV)
                     && startV < opts.HighestVersion && opts.HighestVersion < currentV)
                 {
-                    // New file, tell the Indexer to be careful
-                    opts.Staged = true;
-                    opts.StagingReasons.Add($"Auto-epoching out of order version: {startV} < {opts.HighestVersion} < {currentV}");
+                    if (opts.FlakyAPI)
+                    {
+                        throw new Kraken($"Out-of-order version found on unreliable server: {startV} < {opts.HighestVersion} < {currentV}");
+                    }
+                    else
+                    {
+                        // New file, tell the Indexer to be careful
+                        opts.Staged = true;
+                        opts.StagingReasons.Add($"Auto-epoching out of order version: {startV} < {opts.HighestVersion} < {currentV}");
+                    }
                 }
                 json["version"] = currentV.ToString();
             }

diff --git a/Netkan/Transformers/GithubTransformer.cs b/Netkan/Transformers/GithubTransformer.cs
@@ -38,6 +38,9 @@ public IEnumerable<Metadata> Transform(Metadata metadata, TransformOptions opts)
             {
                 var json = metadata.Json();
 
+                // Tell downstream translators that this host's API is unreliable
+                opts.FlakyAPI = true;
+
                 Log.InfoFormat("Executing GitHub transformation with {0}", metadata.Kref);
                 Log.DebugFormat("Input metadata:{0}{1}", Environment.NewLine, json);
 

diff --git a/Netkan/Transformers/ITransformer.cs b/Netkan/Transformers/ITransformer.cs
@@ -24,6 +24,7 @@ public TransformOptions(int? releases, int? skipReleases, ModuleVersion highVer,
         public readonly ModuleVersion HighestVersion;
         public          bool          Staged;
         public readonly List<string>  StagingReasons;
+        public          bool          FlakyAPI = false;
     }
 
     /// <summary>