Skip to content

Commit

Permalink
Exclude flaky network tests from being run by travis.
Browse files Browse the repository at this point in the history
These can ruin our day if they fail bogusly.
  • Loading branch information
pjf committed Oct 24, 2014
1 parent 4d0aa16 commit 4dced9e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ install:
script:
- cd CKAN
- xbuild CKAN.sln
- nunit-console Tests/bin/Debug/Tests.dll
- nunit-console --exclude=FlakyNetwork Tests/bin/Debug/Tests.dll

before_deploy:
- cd ..
Expand Down
7 changes: 7 additions & 0 deletions CKAN/Tests/KerbalStuff/GitHubTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@ namespace NetKAN.GitHubTests
[TestFixture()]
public class GithubAPITests
{

// Ironically, despite the fact that these run on travis-ci, which is strongly integrated
// to github, these sometimes cause test failures because github will throw random
// 403s. (Hence we disable them in travis with --exclude=FlakyNetwork)

[Test()]
[Category("FlakyNetwork")]
public void Release ()
{
GithubRelease ckan = CKAN.KerbalStuff.GithubAPI.GetLatestRelease("KSP-CKAN/Test");
Expand All @@ -18,6 +24,7 @@ public void Release ()
}

[Test()]
[Category("FlakyNetwork")]
public void TestGithubRelease()
{
Assert.AreEqual(GithubRelease.GithubPage("KSP-CKAN/CKAN"), "https://github.com/KSP-CKAN/CKAN");
Expand Down

0 comments on commit 4dced9e

Please sign in to comment.