Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed string formatting errors #6

Closed
wants to merge 11 commits into from

Conversation

hedin-hiervard
Copy link

Prevented the logger to work in Godot 3.1.alpha1

@bojidar-bg bojidar-bg requested a review from akien-mga February 18, 2019 10:19
@mitchcurtis
Copy link

mitchcurtis commented Apr 11, 2019

So is this project dead? Should I use your repo instead, @hedin-hiervard?

I get a bunch of errors after setting this to autoload (which seem to be fixed with your patches):

res://3rdparty/logger/logger.gd:382 - Parse Error: Too many arguments for 'warn()' call. Expected at most 2.
modules/gdscript/gdscript.cpp:580 - Method/Function Failed, returning: ERR_PARSE_ERROR
Script does not inherit a Node: res://3rdparty/logger/logger.gd
editor/editor_autoload_settings.cpp:448 - Condition ' !info->node ' is true. Continuing..:
Add AutoLoad
res://3rdparty/logger/logger.gd:382 - Parse Error: Too many arguments for 'warn()' call. Expected at most 2.
modules/gdscript/gdscript.cpp:580 - Method/Function Failed, returning: ERR_PARSE_ERROR

@hedin-hiervard
Copy link
Author

Feel free to use and contribute. I use this
fork for my game Dwarven Skykeep.

@akien-mga
Copy link
Member

The first two commits look good, but the rest should go in separate PRs, as they're unrelated to fixing string formatting.

The third commit also breaks compatibility by changing the names of the logging levels in a seemingly arbitrary manner, so this would need discussion.

@SirMoM SirMoM mentioned this pull request Sep 30, 2020
@Calinou Calinou added the bug label Oct 16, 2020
@SirMoM
Copy link
Contributor

SirMoM commented Oct 20, 2020

I think this can be closed since the errors of this PR are already resolved in #8.

@akien-mga
Copy link
Member

Closing as superseded by later PRs. Thanks for the contribution!

@akien-mga akien-mga closed this Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants