CI/CD: This changes the linter config to adhere to "our" codestyle #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the enum format to the const format sice enums are treated as consts. The linter now ignores unused parameters which are used by the ExternalSink subclass.
|
I also don't know why the CI/CD workflow is not able to check out the repository and thus failing.... But my flow is working: https://github.com/SirMoM/godot-logger/runs/2649944940 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the enum format to the const format sice enums are treated
as constants.
The linter now ignores unused parameters which are used by the
ExternalSink subclass.
@akien-mga This should fix some problems from #16
It is still up for debate if the CI/CD pipeline should format the code automagically?