Refactor hid.py #1068
Merged
Refactor hid.py #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Small memory and performance improvements, mostly const() and bytearray ops. * Separate out report specific code into report classes. Serves as a base for easier addition of custom endpoints in "the future". * Lots of small integration changes, for example a simpler mechanism to record reports for unit tests (now with potential to verify other reports than 6KRO).
regicidalplutophage
requested changes
Jan 8, 2025
kmk/hid.py
Outdated
| # active at any time. | ||
| memoryview(self._cc_report)[1:3] = cc.code.to_bytes(2, 'little') | ||
| self._cc_pending = True | ||
| class HSPointingDeviceReport(Report): |
There was a problem hiding this comment.
Shouldn't this inherit from PointingDeviceReport?
class HSPointingDeviceReport(PointingDeviceReport):There was a problem hiding this comment.
That is correct.
I found even more bits and pieces that escaped the rebase. Also, you're now partially responsible for #1069.
regicidalplutophage
approved these changes
Jan 8, 2025
|
Tested all the endpoint configurations again, pretty sure it's complete now. If not, I probably have a fix for it somewhere already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big one. It started out as smaller atomic commits, but the recent #1061 made a clean rebase a bad decision from the perspective of time and effort that would have been spent on it.
Summary: