Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flavour fields #5

Merged
merged 3 commits into from
Mar 3, 2021
Merged

Fix flavour fields #5

merged 3 commits into from
Mar 3, 2021

Conversation

8me
Copy link
Contributor

@8me 8me commented Mar 2, 2021

The flavour fields in the returned AxisArray are accidentally fixed to 3, but the number can vary with respect to the chosen model.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #5 (995bc71) into master (1346b0c) will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   87.20%   87.55%   +0.35%     
==========================================
  Files           4        4              
  Lines         211      217       +6     
==========================================
+ Hits          184      190       +6     
  Misses         27       27              
Impacted Files Coverage Δ
src/Matter.jl 86.36% <100.00%> (+0.31%) ⬆️
src/Oscillation.jl 88.72% <100.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1346b0c...995bc71. Read the comment docs.

Copy link
Member

@tamasgal tamasgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tamasgal
Copy link
Member

tamasgal commented Mar 2, 2021

Is this done? If so, we can merge.

@8me 8me merged commit 02a5959 into master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants