feat: add support for delegation deposit reclaim #436
Conversation
| @@ -64,7 +65,7 @@ export class DelegationNode implements IDelegationNode { | |||
| public readonly id: IDelegationNode['id'] | |||
| public readonly hierarchyId: IDelegationNode['hierarchyId'] | |||
| public readonly parentId?: IDelegationNode['parentId'] | |||
| public readonly childrenIds: Array<IDelegationNode['id']> = [] | |||
| private childrenIdentifiers: Array<IDelegationNode['id']> = [] | |||
There was a problem hiding this comment.
Since we are using id everywhere else I would suggest to either change to match or change elsewhere to identifier
There was a problem hiding this comment.
Yes but I had to make childrenIds a public getter, while also having a private variables, and they could not be called the same. Plus, using a leading _ would trigger lint warnings. I did not find any other way to expose what I needed to expose.
There was a problem hiding this comment.
Why do they need to be private? (also note, that after transpiling to javascript, it is not private anymore, just a hint for people working with typescript)
There was a problem hiding this comment.
Yeah the idea is to follow, where possible, object-oriented encapsulation. Ok that with JS we lose all this nice info, but for TS developers it should not be possible to alter the array of children without revoking them. That is why I did not want to publicly expose it.
|
The tests are also failing. |
|
The issues with tests is because we are mistakenly referring to the [EDIT] |
Add support for delegation deposit reclaim
This PR fixes https://github.com/KILTprotocol/ticket/issues/1685 by adding a new function on
DelegationNodeand the relative chain file to generate aSubmittableExtrinsicfor thereclaim_depositchain function.This PR targets
developcommit KILTprotocol/kilt-node@fc56483 andmastercommit KILTprotocol/kilt-node@dff5ae8 (integration tests for this branch are failing as delegation deposits have not yet been merged).Companion PR (already merged on
develop) -> KILTprotocol/kilt-node#295Checklist: