chore: e2e tests ah between current spiritnet runtime #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntn-x2
reviewed
Jul 17, 2024
| @@ -26,6 +26,14 @@ export function setGovernance(addr: string[]) { | |||
| } | |||
| } | |||
|
|
|||
| export function setSafeXcmVersion3() { | |||
There was a problem hiding this comment.
This only returns something, right? It does not set anything, as far as I can see.
There was a problem hiding this comment.
Yes, not the best naming. I renamed in: 3c3d182
There was a problem hiding this comment.
Let's go with getSafeXcmVersion3StorageEntry, and make it unambiguous.
There was a problem hiding this comment.
Or XcmPalletSafeVersion3StorageEntry.
There was a problem hiding this comment.
I guess TS practice is to start the name lowercase 😇
...ks/src/tests/xcm/assetHub/__snapshots__/limitedReserveTransferAssetHubSpiritnet.test.ts.snap
Outdated
Show resolved
Hide resolved
...tion-tests/chopsticks/src/tests/xcm/assetHub/limitedReserveTransferAssetHubSpiritnet.test.ts
Show resolved
Hide resolved
...tion-tests/chopsticks/src/tests/xcm/assetHub/limitedReserveTransferSpiritnetAssetHub.test.ts
Outdated
Show resolved
Hide resolved
2140bc7 to
9e3487e
Compare
ntn-x2
approved these changes
Jul 19, 2024
ntn-x2
requested changes
Jul 19, 2024
…t-node into ag_ah_integration_tests
|
Updated snapshots in: 5f11861 |
ntn-x2
approved these changes
Jul 23, 2024
Ad96el
added a commit
that referenced
this pull request
Aug 20, 2024
## fixes [#3507](KILTprotocol/ticket#3507) Checks possible interaction between AH and Spiritnet. In the emulated tests, it is checked that messages with the `Transact` instruction are filtered out. Currently, there are only tests for extrinsics which require sudo rights. If it is wished, I can add a test for that too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3507
Checks possible interaction between AH and Spiritnet. In the emulated tests, it is checked that messages with the
Transactinstruction are filtered out. Currently, there are only tests for extrinsics which require sudo rights. If it is wished, I can add a test for that too.