Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: automate snapshot updates #636

Closed
wants to merge 23 commits into from
Closed

ci: automate snapshot updates #636

wants to merge 23 commits into from

Conversation

Ad96el
Copy link
Member

@Ad96el Ad96el commented May 16, 2024

fixes KILTProtocol/ticket#3408

According to the Acala approach, this pull request introduces a new GitHub workflow to automatically update the snapshots. The workflow must be triggered manually, resulting in a pull request that can then be approved by us.

Additionally, this PR introduces the currently updated snapshots.

An example PR can be found here: #638

@Ad96el Ad96el changed the title Ag chopsticks ci: automate snapshots update May 16, 2024
@Ad96el Ad96el changed the title ci: automate snapshots update ci: automate snapshot updates May 16, 2024
@Ad96el Ad96el marked this pull request as ready for review May 16, 2024 13:11
@Ad96el Ad96el requested a review from ntn-x2 May 16, 2024 13:25
ntn-x2
ntn-x2 previously approved these changes May 17, 2024
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how it works 👍👍👍

.github/workflows/update-snapshots.yaml Outdated Show resolved Hide resolved
.github/workflows/update-snapshots.yaml Show resolved Hide resolved
await exec.exec(`git config user.email "devs@kilt.io"`)
await exec.exec(`git config user.name "kiltbot"`)
await exec.exec(`git checkout -b ${branchName}`)
await exec.exec(`git`, ['commit', '-am', 'ci: Update snapshots'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we take any actions based on #639 (comment), then this should be updated to reflect that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the label on hold until we found a solution/decision for the other PR

@Ad96el Ad96el added the ✋on hold status: on hold label May 17, 2024
@ntn-x2
Copy link
Member

ntn-x2 commented May 29, 2024

Closing this for now as it's probably outdated by https://github.com/KILTprotocol/ticket/issues/3252. If needed, we'll opened a new our from develop directly.

@ntn-x2 ntn-x2 closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✋on hold status: on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants