feat: add logging to DIP components #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ad96el
previously approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Nice changes.
Two picky comments. Would be charming if some logs are more consistent. Some start with Failed and some others have the failed in the middle of the sentence, but nothing which should block this PR to be merged.
I assume the integration-tests are currently failing because we are in an intermediate state. I tried to fix them and I get the error Transport("NoChannel").
These errors are probably resolved, once we accept the channel request from HydraDx. Nevertheless, some changes are required. The KILT token registration is no longer necessary. I have fixed them already and will create a PR, once the referendum is through.
Ad96el
previously approved these changes
Apr 23, 2024
Ad96el
pushed a commit
that referenced
this pull request
Aug 20, 2024
Fixes KILTprotocol/ticket#3128. I introduced different new logging targets. For the deposit storage and relay store pallet, which are not technically part of the DIP protocol, the target is a standalone one. For the other things, meaning DIP pallets and DIP provider/consumer components, the log targets have the following structure: `"dip::<provider>|<consumer>::<type_name>"`. So filtering provider logs would require `RUST_LOG=dip::provider=info`, for instance. Most of the logs are `info` level, with some `error` where we return `Internal` errors or errors coalesced into a `u8` value, and a couple of `trace` for the less important stuff to show.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/KILTprotocol/ticket/issues/3128.
I introduced different new logging targets. For the deposit storage and relay store pallet, which are not technically part of the DIP protocol, the target is a standalone one. For the other things, meaning DIP pallets and DIP provider/consumer components, the log targets have the following structure:
"dip::<provider>|<consumer>::<type_name>". So filtering provider logs would requireRUST_LOG=dip::provider=info, for instance. Most of the logs areinfolevel, with someerrorwhere we returnInternalerrors or errors coalesced into au8value, and a couple oftracefor the less important stuff to show.