feat: prepare RILT spec #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Argument group name must be unique" fixes https://github.com/KILTprotocol/ticket/issues/3027
* make spiritnet & peregrine look similar * update script to build RILT spec
ntn-x2
approved these changes
Nov 29, 2023
| @@ -79,15 +79,15 @@ fn load_spec(id: &str) -> std::result::Result<Box<dyn sc_service::ChainSpec>, St | |||
| log::info!("The following runtime was chosen based on the spec id: {}", runtime); | |||
|
|
|||
| match (id, runtime) { | |||
| ("dev", _) => Ok(Box::new(chain_spec::peregrine::make_dev_spec()?)), | |||
| ("dev", _) => Ok(Box::new(chain_spec::peregrine::get_chain_spec_dev()?)), | |||
There was a problem hiding this comment.
I guess adding peregrine somewhere in the name of the function would make it less confusing.
Ad96el
approved these changes
Nov 30, 2023
@Ad96el We have a file for each runtime. There are only two runtimes, Spiritnet and Peregrine. You probably mean for each runtime configuration. That would make sense. |
|
Ah yes, thank you for pointing that out. |
Ad96el
pushed a commit
that referenced
this pull request
Feb 7, 2024
Ad96el
pushed a commit
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/KILTprotocol/ticket/issues/2522
Metadata Diff to Develop Branch
Peregrine Diff
Spiritnet Diff
Checklist:
array[3]useget(3), ...)