feat: single signature DID calls/creation #551

weichweich · 2023-08-21T14:27:07Z

fix https://github.com/KILTprotocol/ticket/issues/2849

This PR enables blockchain accounts to manage DIDs on the KILT chain.

Sending DID calls and creating DIDs will be possible with any substrate enabled wallet (polkadotJS, Nova, ...).

Creating a DID will also be possible but still requires two signatures. By supporting wrapped payloads as a special signature type, wallets that support signRaw or similar will be able to create DIDs. With this wrapped type the default way of sending DIDCalls would also work, but still require a second signature.

Metadata Diff to Develop Branch

Peregrine Diff

!!! THE SUBWASM REDUCED DIFFER IS EXPERIMENTAL, DOUBLE CHECK THE RESULTS !!!
[≠] pallet 64: Did -> 5 change(s)
  - calls changes:
    [≠]  1: set_authentication_key ( new_key: DidVerificationKey, )  )
        [Signature(SignatureChange { args: [Changed(0, [Ty(StringChange("DidVerificationKey", "DidVerificationKey<AccountIdOf<T>>"))])] })]
    [≠]  2: set_delegation_key ( new_key: DidVerificationKey, )  )
        [Signature(SignatureChange { args: [Changed(0, [Ty(StringChange("DidVerificationKey", "DidVerificationKey<AccountIdOf<T>>"))])] })]
    [≠]  4: set_attestation_key ( new_key: DidVerificationKey, )  )
        [Signature(SignatureChange { args: [Changed(0, [Ty(StringChange("DidVerificationKey", "DidVerificationKey<AccountIdOf<T>>"))])] })]
    [+] CallDesc { index: 15, name: "dispatch_as", signature: SignatureDesc { args: [ArgDesc { name: "did_identifier", ty: "DidIdentifierOf<T>" }, ArgDesc { name: "call", ty: "Box<DidCallableOf<T>>" }] } }
    [+] CallDesc { index: 16, name: "create_from_account", signature: SignatureDesc { args: [ArgDesc { name: "authentication_key", ty: "DidVerificationKey<AccountIdOf<T>>" }] } }

SUMMARY:
- Compatible.......................: false
- Require transaction_version bump.: false

!!! THE SUBWASM REDUCED DIFFER IS EXPERIMENTAL, DOUBLE CHECK THE RESULTS !!!

Spiritnet Diff

!!! THE SUBWASM REDUCED DIFFER IS EXPERIMENTAL, DOUBLE CHECK THE RESULTS !!!
[≠] pallet 64: Did -> 5 change(s)
  - calls changes:
    [≠]  1: set_authentication_key ( new_key: DidVerificationKey, )  )
        [Signature(SignatureChange { args: [Changed(0, [Ty(StringChange("DidVerificationKey", "DidVerificationKey<AccountIdOf<T>>"))])] })]
    [≠]  2: set_delegation_key ( new_key: DidVerificationKey, )  )
        [Signature(SignatureChange { args: [Changed(0, [Ty(StringChange("DidVerificationKey", "DidVerificationKey<AccountIdOf<T>>"))])] })]
    [≠]  4: set_attestation_key ( new_key: DidVerificationKey, )  )
        [Signature(SignatureChange { args: [Changed(0, [Ty(StringChange("DidVerificationKey", "DidVerificationKey<AccountIdOf<T>>"))])] })]
    [+] CallDesc { index: 15, name: "dispatch_as", signature: SignatureDesc { args: [ArgDesc { name: "did_identifier", ty: "DidIdentifierOf<T>" }, ArgDesc { name: "call", ty: "Box<DidCallableOf<T>>" }] } }
    [+] CallDesc { index: 16, name: "create_from_account", signature: SignatureDesc { args: [ArgDesc { name: "authentication_key", ty: "DidVerificationKey<AccountIdOf<T>>" }] } }

SUMMARY:
- Compatible.......................: false
- Require transaction_version bump.: false

!!! THE SUBWASM REDUCED DIFFER IS EXPERIMENTAL, DOUBLE CHECK THE RESULTS !!!

Checklist:

I have verified that the code works
- No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
I have verified that the code is easy to understand
- If not, I have left a well-balanced amount of inline comments
I have left the code in a better state
I have documented the changes (where applicable)
- Either PR or Ticket to update the Docs
- Link the PR/Ticket here

pallets/did/src/lib.rs

pallets/did/src/did_details.rs

dispatch did calls without a second signature

No need to have all the details since we can simply batch update calls with `dispatch_as`.

reorder the tests so that the successful test comes first

weichweich · 2023-09-07T09:04:31Z

pallets/did/src/lib.rs

@@ -79,6 +79,7 @@

 #![cfg_attr(not(feature = "std"), no_std)]
 #![allow(clippy::unused_unit)]
+#![recursion_limit = "256"]


this was necessary because of the new benchmarks. We probably have too many benchmarks. 😁

weichweich · 2023-09-07T10:57:19Z

pallets/did/src/tests/submit.rs

@@ -28,6 +28,33 @@ use crate::{
 	mock_utils::*,
 };

+#[test]


i pulled the "successful-case" test to the top

weichweich · 2023-09-07T10:57:56Z

runtimes/peregrine/src/weights/did.rs

+		//  Measured:  `353`
+		//  Estimated: `5777`
+		// Minimum execution time: 186_836_000 picoseconds.
+		Weight::from_parts(189_377_000, 0)


weights will be calculated on our benchmark server. They were done with debug builds

Ad96el

3 minor comments. I like the modular test setup. 🥳

pallets/did/src/lib.rs

pallets/did/src/did_details.rs

pallets/did/src/lib.rs

ntn-x2

Love it! I just don't understand why the widespread use of AsRef<[u8]> for DID keys?

pallets/did/src/lib.rs

pallets/did/src/did_details.rs

pallets/did/src/lib.rs

This enables individual tests for each benchmark.

weichweich commented Aug 30, 2023

View reviewed changes

pallets/did/src/lib.rs Outdated Show resolved Hide resolved

pallets/did/src/lib.rs Outdated Show resolved Hide resolved

pallets/did/src/did_details.rs Outdated Show resolved Hide resolved

weichweich added 4 commits August 31, 2023 12:17

Don't use true and false to generate two different keys

b178b23

remove not necesarry trait bounds

d0d774a

split tests

84bd0d6

Merge remote-tracking branch 'origin/develop' into did-test-update

4a2da5d

This was referenced Aug 31, 2023

refactor: split up DID creation #2 #350

Closed

refactor: DID authorisation logic #351

Closed

feat: call in did creation #379

Closed

weichweich added 8 commits August 31, 2023 16:40

feat: do_did_call

3789ae4

dispatch did calls without a second signature

feat: wrapped payload support

9671f4c

fix: simplify do_did_call

8fdce99

feat: 1/2 create from account

19bf686

check that the sender is the owner of the identifier

3dbbaf8

remove wrapped signatures

5e55104

fix tests

78fc469

simplify create_from_account

fe32789

No need to have all the details since we can simply batch update calls with `dispatch_as`.

weichweich force-pushed the aw-did-origins branch from f5cba9b to fe32789 Compare August 31, 2023 15:01

weichweich added 9 commits September 5, 2023 12:37

Merge remote-tracking branch 'origin/develop' into aw-did-origins

fa82cc3

tests: create_from_account

cdfadd4

🧹🐢

853c843

refactor: successful test first

4c6341b

reorder the tests so that the successful test comes first

tests

5076619

🧹🐢

2f64a2e

🧹🐢

7f362a2

benchmarks

e27f92e

benchmark values

346f404

weichweich commented Sep 7, 2023

View reviewed changes

doc

f8fef1a

weichweich commented Sep 7, 2023

View reviewed changes

weichweich changed the title ~~feat: do_did_call~~ feat: single signature DID calls/creation Sep 7, 2023

weichweich requested a review from ntn-x2 September 7, 2023 10:58

weichweich marked this pull request as ready for review September 7, 2023 10:58

weichweich requested a review from Ad96el September 7, 2023 10:58

Merge branch 'develop' into aw-did-origins

6d68a81

Ad96el reviewed Sep 11, 2023

View reviewed changes

explain hashing

5a6a650

ntn-x2 reviewed Sep 12, 2023

View reviewed changes

pallets/did/src/lib.rs Outdated Show resolved Hide resolved

weichweich added 9 commits September 12, 2023 14:32

Removed unnecessary impl AsRef<[u8]>

e9ddbd4

use IdentifyAccount

d04c0e1

drop the requirement that auth key == did identifier

a8090e5

refactor: create DID function

11c4fa4

refactor: update DID

602a0f7

🧹🐢

f95667c

doc: add docs

cfa486d

refactor: merge new and from_account

9b139f6

doc

7c33b9c

ntn-x2 approved these changes Sep 18, 2023

View reviewed changes

Ad96el approved these changes Sep 18, 2023

View reviewed changes

weichweich added 2 commits September 18, 2023 14:37

chore: move to new benchmark tests.

c70e21c

This enables individual tests for each benchmark.

fix benchmarks

cc089f0

weichweich enabled auto-merge (squash) September 18, 2023 13:31

weichweich merged commit e30d652 into develop Sep 18, 2023

weichweich deleted the aw-did-origins branch September 18, 2023 13:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: single signature DID calls/creation #551

feat: single signature DID calls/creation #551

weichweich commented Aug 21, 2023 •

edited

Loading

weichweich Sep 7, 2023

weichweich Sep 7, 2023

weichweich Sep 7, 2023 •

edited

Loading

Ad96el left a comment

ntn-x2 left a comment

feat: single signature DID calls/creation #551

feat: single signature DID calls/creation #551

Conversation

weichweich commented Aug 21, 2023 • edited Loading

fix https://github.com/KILTprotocol/ticket/issues/2849

Metadata Diff to Develop Branch

Checklist:

weichweich Sep 7, 2023

Choose a reason for hiding this comment

weichweich Sep 7, 2023

Choose a reason for hiding this comment

weichweich Sep 7, 2023 • edited Loading

Choose a reason for hiding this comment

Ad96el left a comment

Choose a reason for hiding this comment

ntn-x2 left a comment

Choose a reason for hiding this comment

weichweich commented Aug 21, 2023 •

edited

Loading

weichweich Sep 7, 2023 •

edited

Loading