Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configuration pallet #522

Merged
merged 12 commits into from
May 25, 2023
Merged

feat: configuration pallet #522

merged 12 commits into from
May 25, 2023

Conversation

weichweich
Copy link
Contributor

@weichweich weichweich commented May 24, 2023 •
edited
Loading

related https://github.com/KILTprotocol/ticket/issues/2522

This PR adds a configuration pallet that dynamically enables strict blocknumber checks.

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@weichweich weichweich requested review from ntn-x2 and Ad96el May 24, 2023 12:44
ntn-x2
ntn-x2 reviewed May 25, 2023
View reviewed changes
runtimes/peregrine/src/lib.rs Outdated Show resolved Hide resolved
pallets/pallet-configuration/src/lib.rs Outdated Show resolved Hide resolved
pallets/pallet-configuration/src/lib.rs Show resolved Hide resolved
@weichweich weichweich enabled auto-merge (squash) May 25, 2023 07:52
@weichweich weichweich merged commit 15e73a1 into develop May 25, 2023
@weichweich weichweich deleted the aw-pere-config branch May 25, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntn-x2 ntn-x2 ntn-x2 approved these changes

@Ad96el Ad96el Awaiting requested review from Ad96el

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weichweich @ntn-x2