Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set right env variables for srtool and subwasm #462

Merged
merged 1 commit into from
Feb 9, 2023
Merged

fix: set right env variables for srtool and subwasm #462

merged 1 commit into from
Feb 9, 2023

Conversation

ntn-x2
Copy link
Member

@ntn-x2 ntn-x2 commented Feb 9, 2023

@ntn-x2 ntn-x2 requested review from trusch and weichweich February 9, 2023 09:24
@ntn-x2 ntn-x2 self-assigned this Feb 9, 2023
@ntn-x2 ntn-x2 enabled auto-merge (squash) February 9, 2023 09:32
@ntn-x2 ntn-x2 merged commit 1542371 into develop Feb 9, 2023
@ntn-x2 ntn-x2 deleted the aa/srtool-config-fix branch February 9, 2023 10:01
@wischli
Copy link
Contributor

wischli commented Feb 15, 2023 •
edited
Loading

Would you mind sharing how these prefixes were derived?

@ntn-x2
Copy link
Member Author

ntn-x2 commented Feb 15, 2023

@wischli the PARACHAIN_PALLET_ID is the HEX-converted index of the parachain_system pallet in the runtime, and AUTHORIZE_UPGRADE_PREFIX is the index of the authorize_upgrade call inside the parachain_system pallet. It is set to 3 by default since in the past that used to be the index. Now it's changed, and a PR was merged in srtool to fix the defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weichweich weichweich weichweich approved these changes

@trusch trusch Awaiting requested review from trusch

Assignees

@ntn-x2 ntn-x2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ntn-x2 @wischli @weichweich