Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make clear that it's still under development #451

Merged
merged 1 commit into from
Jan 20, 2023
Merged

chore: make clear that it's still under development #451

merged 1 commit into from
Jan 20, 2023

Conversation

weichweich
Copy link
Contributor

@weichweich weichweich commented Jan 20, 2023 •
edited
Loading

fixes https://github.com/KILTprotocol/ticket/issues/2387

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@weichweich weichweich requested a review from ntn-x2 January 20, 2023 09:38
@ntn-x2
Copy link
Member

ntn-x2 commented Jan 20, 2023

Is this a new convention we are adopting?

ntn-x2
ntn-x2 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see there's a ticket for it. LGTM!

@weichweich weichweich merged commit 79ac365 into develop Jan 20, 2023
@weichweich weichweich deleted the aw-ensure-under-dev branch January 20, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntn-x2 ntn-x2 ntn-x2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weichweich @ntn-x2