Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old DID runtime API in favor of the new one #425

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

ntn-x2
Copy link
Member

@ntn-x2 ntn-x2 commented Oct 19, 2022

Remove all traces of api.call.didApi from the codebase and add a v2 for the api.call.did stuff, since v1 has been released as part of 1.7.5.
The new runtime API will be released as part of 1.8.0

@ntn-x2 ntn-x2 requested review from weichweich and wischli October 19, 2022 14:22
@ntn-x2 ntn-x2 self-assigned this Oct 19, 2022
@ntn-x2 ntn-x2 force-pushed the aa/remove-old-did-runtime-api branch from 1ba34ae to 6f44e8c Compare October 20, 2022 09:57
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@weichweich
Copy link
Contributor

weichweich commented Oct 20, 2022

does this fix https://github.com/KILTprotocol/ticket/issues/2141 or was this fixed already ?

@ntn-x2
Copy link
Member Author

ntn-x2 commented Oct 20, 2022

does this fix https://github.com/KILTprotocol/ticket/issues/2141 or was this fixed already ?

It was fixed as part of #422. I will close that issue. Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants