-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: scale up max delegators per collator to 35 from 25 #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!
@wischli I guess we also need to re-run the benchmarks, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool
Yes! |
/bench runtime spiritnet-runtime parachain-staking |
1 similar comment
/bench runtime spiritnet-runtime parachain-staking |
Benchmark Runtime Pallet for branch "wf-1749-increase-delegators" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=parachain-staking --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/parachain_staking.rs --template=.maintain/runtime-weight-template.hbs Results
|
…hmarks -- benchmark --chain=spiritnet-dev --steps=50 --repeat=20 --pallet=parachain-staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./runtimes/spiritnet/src/weights/parachain_staking.rs --template=.maintain/runtime-weight-template.hbs
/bench runtime pallet parachain-staking |
Benchmark Runtime Pallet for branch "wf-1749-increase-delegators" with command cargo run --quiet --release -p kilt-parachain --features=runtime-benchmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=parachain-staking --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/parachain-staking/src/default_weights.rs --template=.maintain/weight-template.hbs Results
|
…hmarks -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=parachain-staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=pallets/parachain-staking/src/default_weights.rs --template=.maintain/weight-template.hbs
fixes KILTProtocol/ticket#1749
MaxDelegatorsPerCollator
toruntime-common
constant and increases to 35 from 25extend_lock
which did not exist at the point of initially writing the palletChecklist:
array[3]
useget(3)
, ...)