Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rn + move primitives to runtime common #310

Merged
merged 1 commit into from
Jan 12, 2022
Merged

refactor: rn + move primitives to runtime common #310

merged 1 commit into from
Jan 12, 2022

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Jan 11, 2022 •
edited
Loading

fixes KILTProtocol/ticket#1752

  • Renames kilt-primitives to runtime-common and moves from root directory inside runtimes which seems to be the standard
  • M

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@wischli wischli requested review from weichweich and ntn-x2 January 11, 2022 15:21
ntn-x2
ntn-x2 approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

weichweich
weichweich approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@weichweich weichweich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@wischli wischli merged commit e7ebe7a into develop Jan 12, 2022
@wischli wischli deleted the wf-1752-rn-primitives branch January 12, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weichweich weichweich weichweich approved these changes

@ntn-x2 ntn-x2 ntn-x2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wischli @ntn-x2 @weichweich