Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove crowdloan pallet #302

Merged
merged 6 commits into from
Nov 26, 2021
Merged

chore: remove crowdloan pallet #302

merged 6 commits into from
Nov 26, 2021

Conversation

weichweich
Copy link
Contributor

@weichweich weichweich commented Nov 25, 2021 •
edited by ntn-x2
Loading

No Ticket

  • remove and clean the Crowdloan Contributor pallet (it served it's purpose)
  • pay the dust to the treasury

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • This PR does not introduce new custom types
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@weichweich weichweich self-assigned this Nov 25, 2021
@weichweich weichweich requested review from ntn-x2 and wischli November 25, 2021 14:21
ntn-x2
ntn-x2 approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I am just unsure whether it is best to change the pallet and runtime versions inside a PR like this. I would rather change them at the beginning or end of the development cycle with a separate PR.

@weichweich
Copy link
Contributor Author

LGTM! I am just unsure whether it is best to change the pallet and runtime versions inside a PR like this. I would rather change them at the beginning or end of the development cycle with a separate PR.

yes. i reverted the version upgrade

@weichweich weichweich enabled auto-merge (squash) November 26, 2021 08:04
@ntn-x2
Copy link
Member

ntn-x2 commented Nov 26, 2021

I also updated the PR description 👌

wischli
wischli approved these changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weichweich weichweich merged commit a267d9c into develop Nov 26, 2021
@weichweich weichweich deleted the aw-remove-thankyous branch November 26, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wischli wischli wischli approved these changes

@ntn-x2 ntn-x2 ntn-x2 approved these changes

Assignees

@weichweich weichweich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weichweich @ntn-x2 @wischli