Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix imports #301

Merged
merged 5 commits into from
Dec 8, 2021
Merged

refactor: fix imports #301

merged 5 commits into from
Dec 8, 2021

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Nov 19, 2021

fixes KILTProtocol/ticket#1700

  • Removes asterisk imports
  • Removes migrations and deprecated files due to being outdated

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • This PR does not introduce new custom types
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@wischli wischli requested a review from weichweich November 19, 2021 15:09
@wischli wischli requested a review from ntn-x2 December 6, 2021 09:29
@wischli wischli marked this pull request as ready for review December 6, 2021 09:32
@wischli wischli merged commit 4e1f4b6 into develop Dec 8, 2021
@wischli wischli deleted the wf-1700-imports branch December 8, 2021 08:49
weichweich pushed a commit that referenced this pull request Dec 9, 2021
@wischli @weichweich
refactor: fix imports (#301)
06bc9a0 
* refactor: fix imports

* fix: cargo test

* fix: remove unused try-runtime hooks

* fix: clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weichweich weichweich weichweich approved these changes

@ntn-x2 ntn-x2 Awaiting requested review from ntn-x2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wischli @weichweich