Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow join_candidates #287

Merged
merged 2 commits into from
Oct 29, 2021
Merged

feat: allow join_candidates #287

merged 2 commits into from
Oct 29, 2021

Conversation

weichweich
Copy link
Contributor

@weichweich weichweich commented Oct 29, 2021 •
edited
Loading

M

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • This PR does not introduce new custom types
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@weichweich weichweich changed the title feat: allow join_collators feat: allow join_candidates Oct 29, 2021
@weichweich weichweich self-assigned this Oct 29, 2021
wischli
wischli approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weichweich weichweich enabled auto-merge (squash) October 29, 2021 10:18
@weichweich weichweich merged commit 3874c1e into develop Oct 29, 2021
@weichweich weichweich deleted the aw-join-collators branch October 29, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wischli wischli wischli approved these changes

Assignees

@weichweich weichweich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weichweich @wischli