feat: remove sudo #285
feat: remove sudo #285
Conversation
|
Don't have a strong argument in favor of implementing my suggestions, also because the sudo migration will be removed soon, but I think it would still make it easier to read now and in future, if we need a similar approach for other pallets. |
There was a problem hiding this comment.
Don't have a strong argument in favour of implementing my suggestions, especially since the sudo migration will be removed soon. Anyway, I think it would make it easier to read it now and in the future, if we want to apply a similar migration to other pallets.
|
|
||
| log::info!("Pre check Sudo-Removal."); | ||
| let res = frame_support::storage::unhashed::get::<AccountId>(&hex![ | ||
| "5c0d1176a568c1f92944340dbfed9e9c530ebca703c85910e7164cb7d1c9e47b" |
There was a problem hiding this comment.
I would probably derive this value using some function? Like https://docs.substrate.io/rustdocs/latest/frame_support/storage/migration/fn.get_storage_value.html.
|
|
||
| fn on_runtime_upgrade() -> frame_support::weights::Weight { | ||
| // Magic bytes are the sudo pallet prefix | ||
| let _ = frame_support::storage::unhashed::kill_prefix(&hex!["5c0d1176a568c1f92944340dbfed9e9c"], Some(2)); |
There was a problem hiding this comment.
There was a problem hiding this comment.
that would not work since we already get the prefix of a storage entry and not that of a the whole pallet
There was a problem hiding this comment.
i could do twox_128(pallet_name).
M
Checklist:
array[3]useget(3), ...)