fixes

pallets/crowdloan/src/benchmarking.rs

@@ -82,15 +82,14 @@ benchmarks! {
 		let reserve_free: AccountIdOf<T> = account("reserve_free", 0, SEED_1);
 		let reserve_vested: AccountIdOf<T> = account("reserve_vested", 0, SEED_1);
 		RegistrarAccount::<T>::set(registrar.clone());
-
 	}: _(
 		RawOrigin::Signed(registrar),
 		T::Lookup::unlookup(reserve_vested.clone()),
 		T::Lookup::unlookup(reserve_free.clone())
 	)
 	verify {
 		assert_eq!(
-			crate::Reserve::<T>::get(),
+			Reserve::<T>::get(),
 			ReserveAccounts {
 				vested: reserve_vested,
 				free: reserve_free,
@@ -130,11 +129,12 @@ benchmarks! {
 	}: {
 		let call = <Call<T> as Decode>::decode(&mut &*call_enc)
 			.expect("call is encoded above, encoding must be correct");
-		crate::Pallet::<T>::validate_unsigned(source, &call).map_err(|e| -> &'static str { e.into() })?;
+		Pallet::<T>::validate_unsigned(source, &call).map_err(|e| -> &'static str { e.into() })?;
 		call.dispatch_bypass_filter(RawOrigin::None.into())?;
 	}
 	verify {
-		assert!(crate::Contributions::<T>::get(contributor).is_none());
+		assert!(Contributions::<T>::get(contributor.clone()).is_none());
+		assert_eq!(CurrencyOf::<T>::free_balance(&contributor), contribution);
 	}
 
 	remove_contribution {

pallets/crowdloan/src/storage.rs

@@ -31,7 +31,7 @@ pub struct ReserveAccounts<A: Default> {
 /// The configuration of the gratitude.
 #[derive(Clone, Debug, Default, Decode, Encode, PartialEq, TypeInfo)]
 pub struct GratitudeConfig<BlockNumber: Default> {
-	/// The perquintill of vested tokens that are given.
+	/// The permill of vested tokens that are given.
 	pub vested_share: Permill,
 	/// The start block of the vesting.
 	pub start_block: BlockNumber,

pallets/crowdloan/src/tests.rs

@@ -456,8 +456,28 @@ fn validate_unsigned_works() {
 	use sp_runtime::traits::ValidateUnsigned;
 	let source = sp_runtime::transaction_validity::TransactionSource::External;
 	let contributor = ACCOUNT_00;
+	let free_reserve = ACCOUNT_01;
+	let vested_reserve = ACCOUNT_02;
+	let contributor2 = ACCOUNT_03;
+
 	ExtBuilder::default()
-		.with_contributions(vec![(contributor.clone(), BALANCE_02)])
+		.with_contributions(vec![
+			(contributor.clone(), BALANCE_02),
+			(contributor2.clone(), BALANCE_02 + BALANCE_02),
+		])
+		.with_balances(vec![
+			(free_reserve.clone(), BALANCE_01),
+			(vested_reserve.clone(), BALANCE_01),
+		])
+		.with_reserve(ReserveAccounts {
+			vested: vested_reserve,
+			free: free_reserve,
+		})
+		.with_configuration(GratitudeConfig {
+			vested_share: Permill::from_percent(50),
+			start_block: 1,
+			vesting_length: 10,
+		})
 		.build()
 		.execute_with(|| {
 			assert_eq!(
@@ -483,7 +503,17 @@ fn validate_unsigned_works() {
 						receiver: ACCOUNT_02.clone()
 					}
 				),
-				Err(InvalidTransaction::BadProof.into())
+				Err(InvalidTransaction::Custom(crate::ValidityError::NoContributor as u8).into())
+			);
+
+			assert_eq!(
+				crate::Pallet::<Test>::validate_unsigned(
+					source,
+					&crate::Call::receive_gratitude {
+						receiver: contributor2
+					}
+				),
+				Err(InvalidTransaction::Custom(crate::ValidityError::CannotSendGratitude as u8).into())
 			);
 
 			assert_eq!(