Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency org.jetbrains.kotlin.multiplatform to v2 #377

Merged
merged 4 commits into from
May 29, 2024

Conversation

juul-mobile-bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
org.jetbrains.kotlin.multiplatform plugin major 1.9.24 -> 2.0.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@juul-mobile-bot juul-mobile-bot requested a review from a team as a code owner May 24, 2024 09:13
@cedrickcooke cedrickcooke self-assigned this May 24, 2024
@cedrickcooke
Copy link
Contributor

Compilation failures were in @Deprecated code, so now seems like a great time to go for 8.0

@cedrickcooke cedrickcooke added this to the 8.0.0 milestone May 24, 2024
@cedrickcooke cedrickcooke added major Changes that should bump the MAJOR version number and removed renovate labels May 24, 2024
@cedrickcooke cedrickcooke requested a review from twyatt May 24, 2024 17:24
@@ -1,9 +1,10 @@
*.iml
.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File was sorted, and /.kotlin folder was added

Copy link

github-actions bot commented May 24, 2024

Test Results

 61 files   -  39   61 suites   - 39   19s ⏱️ +7s
369 tests  - 476  360 ✅  - 476   9 💤 ±0  0 ❌ ±0 
386 runs   - 476  372 ✅  - 476  14 💤 ±0  0 ❌ ±0 

Results for commit e134bb5. ± Comparison against base commit 1b9cf33.

This pull request removes 476 tests.
com.juul.tuulbox.encoding.Base64Tests ‑ decodeBase64Sequence_forRfcTestVectors_matchesRfc[iosSimulatorArm64]
com.juul.tuulbox.encoding.Base64Tests ‑ decodeBase64Sequence_forRfcTestVectors_matchesRfc[js, browser, ChromeHeadless124.0.6367.208, MacOS10.15.7]
com.juul.tuulbox.encoding.Base64Tests ‑ decodeBase64Sequence_forRfcTestVectors_matchesRfc[jvm]
com.juul.tuulbox.encoding.Base64Tests ‑ decodeBase64Sequence_forRfcTestVectors_matchesRfc[macosArm64]
com.juul.tuulbox.encoding.Base64Tests ‑ decodeBase64Sequence_withOmittedPadding_isRecoverable[iosSimulatorArm64]
com.juul.tuulbox.encoding.Base64Tests ‑ decodeBase64Sequence_withOmittedPadding_isRecoverable[js, browser, ChromeHeadless124.0.6367.208, MacOS10.15.7]
com.juul.tuulbox.encoding.Base64Tests ‑ decodeBase64Sequence_withOmittedPadding_isRecoverable[jvm]
com.juul.tuulbox.encoding.Base64Tests ‑ decodeBase64Sequence_withOmittedPadding_isRecoverable[macosArm64]
com.juul.tuulbox.encoding.Base64Tests ‑ decodeBase64_forRfcTestVectors_matchesRfc[iosSimulatorArm64]
com.juul.tuulbox.encoding.Base64Tests ‑ decodeBase64_forRfcTestVectors_matchesRfc[js, browser, ChromeHeadless124.0.6367.208, MacOS10.15.7]
…

♻️ This comment has been updated with latest results.

Copy link
Member

@twyatt twyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove from readme:

  • assertSimilar under Test section
  • appropriate dependency definitions from Setup: Gradle section

@twyatt twyatt requested a review from cedrickcooke May 28, 2024 17:00
@cedrickcooke cedrickcooke enabled auto-merge (squash) May 28, 2024 17:45
@cedrickcooke cedrickcooke merged commit 338a7c1 into main May 29, 2024
3 checks passed
@cedrickcooke cedrickcooke deleted the renovate/major-kotlin branch May 29, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Changes that should bump the MAJOR version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants