Mark BroadcastReceiver.onReceive parameters as non-null
#358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Android examples] show parameters as non-`null`; additionally, per "can ever the intent received by a BroadcastReceiver be null?" on [Stackoverflow]: > `onReceive` in a `BroadcastReceiver` is triggered by an `Intent` with > an action that it's registered to. So without `Intent` being an > instance of `Intent` and not `null`, the `onReceive` method would > never get called. It would also be better to throw an NPE (and be made aware of a bug) than for it to fail silently (and never emit a value). [Android examples]: https://developer.android.com/develop/background-work/background-tasks/broadcasts#receiving-broadcasts [Stackoverflow]: https://stackoverflow.com/a/17535679
cedrickcooke
approved these changes
Mar 22, 2024
davertay-j
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android examples show parameters as non-
null; additionally, per "can ever the intent received by a BroadcastReceiver be null?" on Stackoverflow:It would also be better to throw an NPE (and be made aware of a bug) than for it to fail silently (and never emit a value).