-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower JVM toolchain down to 8 #268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b4ebe1
to
d491e34
Compare
d491e34
to
c085c4c
Compare
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
============================================
- Coverage 94.44% 85.46% -8.99%
- Complexity 51 91 +40
============================================
Files 13 20 +7
Lines 126 282 +156
Branches 8 15 +7
============================================
+ Hits 119 241 +122
- Misses 6 37 +31
- Partials 1 4 +3
|
QuantumRand
approved these changes
May 2, 2023
Phoenix7351
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #261, the JDK version used on CI was bumped up to
17
for compatibility with Android Gradle plugin (AGP) 8.0+; but the source and target compatibilities were also bumped in that PR.This PR reverts the source and target compatibilities bumps so that library consumers aren't forced to bump their JDK versions (if they're still on JDK 8).