Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower JVM toolchain down to 8 #268

Merged
merged 2 commits into from
May 2, 2023
Merged

Lower JVM toolchain down to 8 #268

merged 2 commits into from
May 2, 2023

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented May 1, 2023

With #261, the JDK version used on CI was bumped up to 17 for compatibility with Android Gradle plugin (AGP) 8.0+; but the source and target compatibilities were also bumped in that PR.

This PR reverts the source and target compatibilities bumps so that library consumers aren't forced to bump their JDK versions (if they're still on JDK 8).

@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label May 1, 2023
@twyatt twyatt added this to the 6.4.1 milestone May 1, 2023
@twyatt twyatt force-pushed the twyatt/java-compatibility branch from 6b4ebe1 to d491e34 Compare May 1, 2023 21:16
@twyatt twyatt changed the title Drop JVM toolchain down to 8 Lower JVM toolchain down to 8 May 1, 2023
@twyatt twyatt marked this pull request as ready for review May 1, 2023 21:57
@twyatt twyatt requested a review from a team as a code owner May 1, 2023 21:57
@twyatt twyatt requested review from Phoenix7351 and davertay-j May 1, 2023 21:57
@twyatt twyatt force-pushed the twyatt/java-compatibility branch from d491e34 to c085c4c Compare May 1, 2023 22:00
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #268 (c085c4c) into main (1c1547e) will decrease coverage by 8.99%.
The diff coverage is 80.27%.

❗ Current head c085c4c differs from pull request most recent head 0c43b40. Consider uploading reports for the commit 0c43b40 to get more accurate results

@@             Coverage Diff              @@
##               main     #268      +/-   ##
============================================
- Coverage     94.44%   85.46%   -8.99%     
- Complexity       51       91      +40     
============================================
  Files            13       20       +7     
  Lines           126      282     +156     
  Branches          8       15       +7     
============================================
+ Hits            119      241     +122     
- Misses            6       37      +31     
- Partials          1        4       +3     
Impacted Files Coverage Δ
coroutines/src/commonMain/kotlin/flow/Combine.kt 0.00% <ø> (ø)
logging/src/commonMain/kotlin/Metadata.kt 76.92% <0.00%> (-0.86%) ⬇️
logging/src/commonMain/kotlin/Sensitivity.kt 0.00% <0.00%> (ø)
...tines/src/commonMain/kotlin/delay/DelayStrategy.kt 47.50% <47.50%> (ø)
logging/src/commonMain/kotlin/DispatchLogger.kt 92.10% <89.65%> (-7.90%) ⬇️
logging/src/commonMain/kotlin/Log.kt 98.27% <93.75%> (-1.73%) ⬇️
logging/src/commonMain/kotlin/FilterLogger.kt 95.65% <95.65%> (ø)
...t/src/commonMain/kotlin/TuulboxKtorClientLogger.kt 100.00% <100.00%> (ø)
logging/src/commonMain/kotlin/FilterLevelLogger.kt 100.00% <100.00%> (ø)
logging/src/commonMain/kotlin/LogLevel.kt 100.00% <100.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes

@github-actions
Copy link

github-actions bot commented May 1, 2023

Test Results

  32 files    32 suites   7s ⏱️
233 tests 226 ✔️   7 💤 0
250 runs  238 ✔️ 12 💤 0

Results for commit 0c43b40.

♻️ This comment has been updated with latest results.

@twyatt twyatt enabled auto-merge (squash) May 2, 2023 17:24
@twyatt twyatt merged commit 77aed3c into main May 2, 2023
@twyatt twyatt deleted the twyatt/java-compatibility branch May 2, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants