Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update com.squareup.okio #63

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Update com.squareup.okio #63

merged 3 commits into from
Dec 21, 2021

Conversation

juul-mobile-bot
Copy link
Contributor

@juul-mobile-bot juul-mobile-bot commented Dec 17, 2021

This PR contains the following updates:

Package Update Change
com.squareup.okio:okio-multiplatform patch 3.0.0-alpha.6 -> 3.0.0-alpha.9
com.squareup.okio:okio-js patch 3.0.0-alpha.6 -> 3.0.0

Release Notes

square/okio

v3.0.0-alpha.9

2021-08-01

  • New: ByteString.copyInto() saves an allocation when extracting data from a ByteString.
  • Fix: Create FileHandle.protectedSize() to match other abstract functions.
  • Fix: Open files in binary mode on Windows. Without this, files that contain 0x1a will be
    truncated prematurely.

v3.0.0-alpha.8

2021-07-13

  • Fix: Don't crash on duplicate entries in a .zip file.
  • Fix: Change FileSystem.RESOURCES to initialize itself lazily.

v3.0.0-alpha.7

2021-07-12

  • Fix: Change ResourceFileSystem to load roots eagerly. We had a bug where list() on the root
    returned an empty list even if resources were present.
  • New: FileHandle.reposition() can seek on a source or sink returned by that FileHandle.
  • New: Move the system resources instance to FileSystem.RESOURCES.
  • Upgrade: [Kotlin 1.5.20][kotlin_1_5_20].

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

@juul-mobile-bot juul-mobile-bot requested review from a team and QuantumRand December 17, 2021 07:05
@juul-mobile-bot juul-mobile-bot force-pushed the renovate/com.squareup.okio branch 2 times, most recently from a3ae184 to 1c87fb7 Compare December 17, 2021 18:42
@twyatt twyatt added the skip-changelog Excludes issue/PR from generated release change log. label Dec 17, 2021
@juul-mobile-bot juul-mobile-bot force-pushed the renovate/com.squareup.okio branch from 1c87fb7 to 06a4672 Compare December 17, 2021 22:00
@twyatt
Copy link
Member

twyatt commented Dec 18, 2021

I'm not sure what is going on with the later versions of Okio, but they are showing up in Maven Central search, but not in the directory listing.

Maven Central search Maven Central directory listing
Screen Shot 2021-12-17 at 4 26 03 PM Screen Shot 2021-12-17 at 4 26 12 PM

Related upstream issue: square/okio#1067

@juul-mobile-bot juul-mobile-bot force-pushed the renovate/com.squareup.okio branch from 06a4672 to d77b479 Compare December 18, 2021 09:03
@juul-mobile-bot juul-mobile-bot force-pushed the renovate/com.squareup.okio branch from d77b479 to 5abdf19 Compare December 20, 2021 09:03
@davertay-j
Copy link
Contributor

I'm not sure what is going on with the later versions of Okio, but they are showing up in Maven Central search, but not in the directory listing.

Hidden in the changelog https://square.github.io/okio/changelog/#version-300

If you’re using Okio in a Kotlin Multiplatform project, you’ll need to drop the -multiplatform suffix in your Gradle dependencies.

@davertay-j davertay-j enabled auto-merge (squash) December 20, 2021 21:28
@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #63 (6c96caa) into main (56a59f1) will increase coverage by 0.23%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #63      +/-   ##
============================================
+ Coverage     57.25%   57.49%   +0.23%     
  Complexity       11       11              
============================================
  Files             8        8              
  Lines           613      654      +41     
  Branches        145      145              
============================================
+ Hits            351      376      +25     
- Misses          223      239      +16     
  Partials         39       39              
Impacted Files Coverage Δ
koap/src/commonMain/kotlin/Message.kt 57.14% <0.00%> (-2.09%) ⬇️
koap/src/commonMain/kotlin/Debug.kt 26.08% <0.00%> (-1.19%) ⬇️
koap/src/commonMain/kotlin/ByteArrayReader.kt 68.08% <0.00%> (-0.10%) ⬇️
koap/src/commonMain/kotlin/Decoder.kt 53.74% <0.00%> (+1.62%) ⬆️
koap/src/commonMain/kotlin/Encoder.kt 71.69% <0.00%> (+3.27%) ⬆️
koap/src/commonMain/kotlin/Option.kt 26.31% <0.00%> (+4.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d94c88a...6c96caa. Read the comment docs.

@twyatt twyatt removed the skip-changelog Excludes issue/PR from generated release change log. label Dec 20, 2021
@twyatt
Copy link
Member

twyatt commented Dec 21, 2021

I'm not sure what is going on with the later versions of Okio, but they are showing up in Maven Central search, but not in the directory listing.

Hidden in the changelog https://square.github.io/okio/changelog/#version-300

If you’re using Okio in a Kotlin Multiplatform project, you’ll need to drop the -multiplatform suffix in your Gradle dependencies.

Wow, good catch! That would've taken me a very long time to realize that! 💯

@davertay-j davertay-j merged commit b32decf into main Dec 21, 2021
@davertay-j davertay-j deleted the renovate/com.squareup.okio branch December 21, 2021 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants