Update to terraform-plugin-framework.

.github/workflows/release.yml

@@ -16,7 +16,8 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v3
         with:
-          go-version: 1.16
+          go-version-file: "go.mod"
+          cache: true
 
       - name: Import GPG key
         id: import_gpg

.github/workflows/terraform-provider-checks.yml

@@ -2,17 +2,55 @@ name: Terraform Provider Checks
 on: [pull_request]
 
 jobs:
+
+  golangci:
+    name: golangci-lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+
+      - uses: actions/setup-go@v3
+        with:
+          go-version-file: "go.mod"
+          cache: true
+
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v3
+        with:
+          # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
+          version: latest
+
+          # Optional: working directory, useful for monorepos
+          # working-directory: somedir
+
+          # Optional: golangci-lint command line arguments.
+          # args: --issues-exit-code=0
+
+          # Optional: show only new issues if it's a pull request. The default value is `false`.
+          # only-new-issues: true
+
+          # Optional: if set to true then the all caching functionality will be complete disabled,
+          #           takes precedence over all other caching options.
+          # skip-cache: true
+
+          # Optional: if set to true then the action don't cache or restore ~/go/pkg.
+          # skip-pkg-cache: true
+
+          # Optional: if set to true then the action don't cache or restore ~/.cache/go-build.
+          # skip-build-cache: true
+
   build:
     name: Build
     runs-on: ubuntu-latest
     steps:
+      - name: Check out code into the Go module directory
+        uses: actions/checkout@v3.0.2
+
       - name: Set up Go 1.x
         uses: actions/setup-go@v3
         with:
-          go-version: ^1.16
-
-      - name: Check out code into the Go module directory
-        uses: actions/checkout@v3.0.2
+          go-version-file: "go.mod"
+          cache: true
 
       - name: Setup dependency cache
         uses: actions/cache@v3.0.1
@@ -34,5 +72,4 @@ jobs:
 
       - name: Test
         run: |
-          make lint
           make test

.go-version

@@ -1 +1 @@
-1.16.5
+1.18.10

.golangci.yml

@@ -8,7 +8,6 @@ issues:
 linters:
   disable-all: true
   enable:
-    - deadcode
     - errcheck
     - gofmt
     - gomnd
@@ -19,11 +18,9 @@ linters:
     - nakedret
     - nilerr
     - staticcheck
-    - structcheck
     - unconvert
     - unused
     - unparam
-    - varcheck
     - vet
 
 linters-settings:

README.md

@@ -3,7 +3,7 @@
 ## Requirements
 
 - [Terraform](https://www.terraform.io/downloads.html) 1.0.1
-- [Go](https://golang.org/doc/install) 1.16 (to build the provider plugin)
+- [Go](https://golang.org/doc/install) 1.18 (to build the provider plugin)
 
 ## Example Usage
 
@@ -22,7 +22,7 @@ Please see the Go documentation for the most up to date information about using
 
 To add a new dependency `github.com/author/dependency` to your Terraform provider:
 
-```
+```shell
 go get github.com/author/dependency
 go mod tidy
 ```
@@ -66,7 +66,7 @@ to your `~/.terraformrc` file. This is valid for Terraform 0.14+. Please see
 [Terraform's documentation](https://www.terraform.io/docs/cli/config/config-file.html#development-overrides-for-provider-developers)
 for more details.
 
-```
+```hcl
 provider_installation {
 
   # Use /home/$USER/go/bin as an overridden package directory

docs/index.md

@@ -21,11 +21,8 @@ provider "jupiterone" {
 <!-- schema generated by tfplugindocs -->
 ## Schema
 
-### Required
+### Optional
 
 - `account_id` (String) JupiterOne account ID to create resources in
 - `api_key` (String, Sensitive) API Key used to make requests to the JupiterOne APIs
-
-### Optional
-
 - `region` (String)

docs/resources/question.md

@@ -3,12 +3,12 @@
 page_title: "jupiterone_question Resource - terraform-provider-jupiterone"
 subcategory: ""
 description: |-
-  
+  A saved JupiterOne Question
 ---
 
 # jupiterone_question (Resource)
 
-
+A saved JupiterOne Question
 
 ## Example Usage
 
@@ -32,41 +32,41 @@ resource "jupiterone_question" "unencrypted_critical_data_stores" {
 ### Required
 
 - `description` (String)
-- `query` (Block List, Min: 1) (see [below for nested schema](#nestedblock--query))
 - `title` (String) The title of the question
 
 ### Optional
 
 - `compliance` (Block List) (see [below for nested schema](#nestedblock--compliance))
+- `query` (Block List) (see [below for nested schema](#nestedblock--query))
 - `tags` (List of String)
 
 ### Read-Only
 
 - `id` (String) The ID of this resource.
 
-<a id="nestedblock--query"></a>
-### Nested Schema for `query`
+<a id="nestedblock--compliance"></a>
+### Nested Schema for `compliance`
 
 Required:
 
-- `query` (String)
-- `version` (String)
+- `standard` (String)
 
 Optional:
 
-- `name` (String)
+- `controls` (List of String)
+- `requirements` (List of String)
 
 
-<a id="nestedblock--compliance"></a>
-### Nested Schema for `compliance`
+<a id="nestedblock--query"></a>
+### Nested Schema for `query`
 
 Required:
 
-- `standard` (String)
+- `query` (String)
+- `version` (String)
 
 Optional:
 
-- `controls` (List of String)
-- `requirements` (List of String)
+- `name` (String)
 
 

docs/resources/rule.md

@@ -3,12 +3,12 @@
 page_title: "jupiterone_rule Resource - terraform-provider-jupiterone"
 subcategory: ""
 description: |-
-  
+  A saved JupiterOne question based alert
 ---
 
 # jupiterone_rule (Resource)
 
-
+A saved JupiterOne question based alert
 
 ## Example Usage
 
@@ -108,7 +108,7 @@ resource "jupiterone_rule" "users_without_mfa" {
 
 - `outputs` (List of String) Names of properties that can be used throughout the rule evaluation process and will be included in each record of a rule evaluation. (e.g. queries.query0.total)
 - `polling_interval` (String) Frequency of automated rule evaluation. Defaults to ONE_DAY.
-- `question` (Block List, Max: 1) Contains properties related to queries used in the rule evaluation. (see [below for nested schema](#nestedblock--question))
+- `question` (Block List) Contains properties related to queries used in the rule evaluation. (see [below for nested schema](#nestedblock--question))
 - `question_id` (String) Specifies the ID of a question to be used in rule evaluation.
 - `question_name` (String, Deprecated) Specifies the name of a question to be used in rule evaluation.
 - `spec_version` (Number) Rule evaluation specification version in the case of breaking changes.
@@ -117,15 +117,15 @@ resource "jupiterone_rule" "users_without_mfa" {
 
 ### Read-Only
 
-- `id` (String) The ID of this resource.
+- `id` (String) Unique id that identifies the rule
 - `version` (Number) Computed current version of the rule. Incremented each time the rule is updated.
 
 <a id="nestedblock--question"></a>
 ### Nested Schema for `question`
 
-Required:
+Optional:
 
-- `queries` (Block List, Min: 1) (see [below for nested schema](#nestedblock--question--queries))
+- `queries` (Block List) Contains properties related to queries used in the rule evaluation. (see [below for nested schema](#nestedblock--question--queries))
 
 <a id="nestedblock--question--queries"></a>
 ### Nested Schema for `question.queries`