-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAJOR - Adapt code to use original vitpose checkpoints and multidataset #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l. Generated new checkpoints with corrected model_split, other minor changes.
The configs present a lot of repeated code, but still they are in better shape than previously. I don't feel they are that important, they are easy to clone now if one wants to experiment fine tuning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial draft PR. Initial reference #8.
idea
Adapt the code to be able to run inference using all the original vitpose models provided by
https://github.com/ViTAE-Transformer/ViTPose
To do so
model_split.py
is used to separate the multidataset checkpoints into single dataset for inference.This should allow to run inference using all the original models on the datasets:
As we also add the support for animal pose estimation we need to adapt the detection phase to non human categories. To do so right now the idea is to simply specify the dataset or coco class to detect, these are the available ones:
I don't think all of them will work during pose estimation but this is the initial idea.
Another solution might be to find a custom trained version specifically for animal detection, I found https://github.com/SaiSwarup27/Animal-Intrusion-Detection which might be promising and uses yolov5 as well. (this will be addressed later)
It might be interesting to allow to specify an external detection process, especially when using
VitInference
directly in a script.Some changes to json saving / inference pipeline and configuration are required.
Also the skeletons must be added one by one to the
json_dict
object to setup visualization.For animals it still feels like integrating a different model might lead to better results.