add missing type to groups attribute

Juniper · Dec 27, 2024 · d5f77fc · d5f77fc
1 parent a9ef5f9
commit d5f77fc
Show file tree

Hide file tree

Showing 5 changed files with 47 additions and 10 deletions.
diff --git a/internal/resource_device_gateway/sdk_to_terraform_tunnel_provider.go b/internal/resource_device_gateway/sdk_to_terraform_tunnel_provider.go
@@ -135,7 +135,7 @@ func tunnelProviderZscalerSdkToTerraform(ctx context.Context, diags *diag.Diagno
 	var dn_bandwidth basetypes.Float64Value
 	var idle_time_in_minutes basetypes.Int64Value
 	var ofw_enabled basetypes.BoolValue
-	var sub_locations basetypes.ListValue
+	var sub_locations basetypes.ListValue = types.ListNull(SubLocationsValue{}.Type(ctx))
 	var surrogate_ip basetypes.BoolValue
 	var surrogate_ip_enforced_for_known_browsers basetypes.BoolValue
 	var surrogate_refresh_time_in_minutes basetypes.Int64Value

diff --git a/internal/resource_org_deviceprofile_gateway/sdk_to_terraform_tunnel_provider.go b/internal/resource_org_deviceprofile_gateway/sdk_to_terraform_tunnel_provider.go
@@ -135,7 +135,7 @@ func tunnelProviderZscalerSdkToTerraform(ctx context.Context, diags *diag.Diagno
 	var dn_bandwidth basetypes.Float64Value
 	var idle_time_in_minutes basetypes.Int64Value
 	var ofw_enabled basetypes.BoolValue
-	var sub_locations basetypes.ListValue
+	var sub_locations basetypes.ListValue = types.ListNull(SubLocationsValue{}.Type(ctx))
 	var surrogate_ip basetypes.BoolValue
 	var surrogate_ip_enforced_for_known_browsers basetypes.BoolValue
 	var surrogate_refresh_time_in_minutes basetypes.Int64Value

diff --git a/internal/resource_org_gatewaytemplate/sdk_to_terraform_tunnel_provider.go b/internal/resource_org_gatewaytemplate/sdk_to_terraform_tunnel_provider.go
@@ -135,7 +135,7 @@ func tunnelProviderZscalerSdkToTerraform(ctx context.Context, diags *diag.Diagno
 	var dn_bandwidth basetypes.Float64Value
 	var idle_time_in_minutes basetypes.Int64Value
 	var ofw_enabled basetypes.BoolValue
-	var sub_locations basetypes.ListValue
+	var sub_locations basetypes.ListValue = types.ListNull(SubLocationsValue{}.Type(ctx))
 	var surrogate_ip basetypes.BoolValue
 	var surrogate_ip_enforced_for_known_browsers basetypes.BoolValue
 	var surrogate_refresh_time_in_minutes basetypes.Int64Value

diff --git a/internal/resource_org_network/sdk_to_terraform_multicast.go b/internal/resource_org_network/sdk_to_terraform_multicast.go
@@ -37,7 +37,7 @@ func groupMutlicastSdkToTerraform(ctx context.Context, diags *diag.Diagnostics,
 func MutlicastSdkToTerraform(ctx context.Context, diags *diag.Diagnostics, d models.NetworkMulticast) MulticastValue {
 	var disable_igmp basetypes.BoolValue
 	var enabled basetypes.BoolValue
-	var groups basetypes.MapValue
+	var groups basetypes.MapValue = types.MapNull(GroupsValue{}.Type(ctx))
 
 	if d.DisableIgmp != nil {
 		disable_igmp = types.BoolValue(*d.DisableIgmp)

diff --git a/templates/guides/release_note_0.2.xx.md b/templates/guides/release_note_0.2.xx.md
@@ -10,6 +10,47 @@ description: |-
 ## Release Notes for v0.2.15
 **release date** : December 27th, 2024
 
+!> Breaking changes
+### Breaking Changes
+* Following attributes have been changes from int64 to string to allow "mist variable" support:
+  * `mist_org_network.internet_access.destination_nat.port`
+  * `mist_org_network.vpn_access.destination_nat.port`
+  * `mist_device_gateway.networks.internet_access.destination_nat.port`
+  * `mist_device_gateway.networks.vpn_access.destination_nat.port`
+  * `mist_deviceprofile_gateway.networks.internet_access.destination_nat.port`
+  * `mist_deviceprofile_gateway.networks.vpn_access.destination_nat.port`
+  * `mist_org_gatewaytemplate.networks.internet_access.destination_nat.port`
+  * `mist_org_gatewaytemplate.networks.vpn_access.destination_nat.port`
+* Following attributes have been changed from `optional` to `required`:
+  * `mist_org_network.internet_access.static_nat.internal_ip`
+  * `mist_org_network.internet_access.static_nat.name`
+  * `mist_org_network.vpn_access.static_nat.internal_ip`
+  * `mist_org_network.vpn_access.static_nat.name`
+  * `mist_device_gateway.tunnel_configs.primary.hosts`
+  * `mist_device_gateway.tunnel_configs.primary.wan_names`
+  * `mist_device_gateway.tunnel_configs.secondary.hosts`
+  * `mist_device_gateway.tunnel_configs.secondary.wan_names`
+  * `mist_device_gateway.networks.internet_access.static_nat.internal_ip`
+  * `mist_device_gateway.networks.internet_access.static_nat.name`
+  * `mist_device_gateway.networks.vpn_access.static_nat.internal_ip`
+  * `mist_device_gateway.networks.vpn_access.static_nat.name`
+  * `mist_deviceprofile_gateway.tunnel_configs.primary.hosts`
+  * `mist_deviceprofile_gateway.tunnel_configs.primary.wan_names`
+  * `mist_deviceprofile_gateway.tunnel_configs.secondary.hosts`
+  * `mist_deviceprofile_gateway.tunnel_configs.secondary.wan_names`
+  * `mist_deviceprofile_gateway.networks.internet_access.static_nat.internal_ip`
+  * `mist_deviceprofile_gateway.networks.internet_access.static_nat.name`
+  * `mist_deviceprofile_gateway.networks.vpn_access.static_nat.internal_ip`
+  * `mist_deviceprofile_gateway.networks.vpn_access.static_nat.name`
+  * `mist_org_gatewaytemplate.tunnel_configs.primary.hosts`
+  * `mist_org_gatewaytemplate.tunnel_configs.primary.wan_names`
+  * `mist_org_gatewaytemplate.tunnel_configs.secondary.hosts`
+  * `mist_org_gatewaytemplate.tunnel_configs.secondary.wan_names`
+  * `mist_org_gatewaytemplate.networks.internet_access.static_nat.internal_ip`
+  * `mist_org_gatewaytemplate.networks.internet_access.static_nat.name`
+  * `mist_org_gatewaytemplate.networks.vpn_access.static_nat.internal_ip`
+  * `mist_org_gatewaytemplate.networks.vpn_access.static_nat.name`
+
 
 ### Improvements
 * add the `api_debug` flag to the provider properties to enable the logging of the SDK Requests and Responses
@@ -27,8 +68,8 @@ Changes to the `mist_org_network` resource based on the OpenAPI changes:
 
 Changes to the `mist_device_gateway`, `mist_deviceprofile_gateway` and `mist_org_gatewaytemplate` resource based on the OpenAPI changes:
 * attributes added:
-  * `internet_access.destination_nat.wan_name`
-  * `internet_access.static_nat.wan_name`
+  * `networks.internet_access.destination_nat.wan_name`
+  * `networks.internet_access.static_nat.wan_name`
   * `port_config.wan_networks`
   * `routing_policies.action.aggregate`
   * `tunnel_configs.auto_provision.primary.probe_ips`
@@ -39,10 +80,6 @@ Changes to the `mist_device_gateway`, `mist_deviceprofile_gateway` and `mist_org
   * `tunnel_configs.auto_provision.primary.num_hosts` (this setting is configured in the `tunnel_provider_options` object)
   * `tunnel_configs.auto_provision.secondary.num_hosts` (this setting is configured in the `tunnel_provider_options` object)
 * attributes updated:
-  * `tunnel_configs.primary.hosts` changed to `required`
-  * `tunnel_configs.primary.wan_names` changed to `required`
-  * `tunnel_configs.secondary.hosts` changed to `required`
-  * `tunnel_configs.secondary.wan_names` changed to `required`
   * `tunnel_provider_options.jse.name` renamed to `tunnel_provider_options.jse.org_name` 
   * rework the whole `tunnel_provider_options.zscaler` object to match the Mist API structure (see the resource documentation for more details)