Fix calculation of endaddress in cppmod ordt_addr_elem_array #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When constructed, the startaddress and endaddress of an ordt_addr_elem_array instance are the start and end addresses of a single element. In the initializer of the ordt_addr_elem base class, the endaddress of the whole array was calculated by adding the stride times the number of reps to the endaddress passed in. This caused the endaddress of the array to be 1 element beyond the end of the array, since the first element was already accounted for. The fix is to add the stride times the reps minus 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructed, the startaddress and endaddress of an ordt_addr_elem_array
instance are the start and end addresses of a single element. In the
initializer of the ordt_addr_elem base class, the endaddress of the whole
array was calculated by adding the stride times the number of reps to the
endaddress passed in. This caused the endaddress of the array to be 1 element
beyond the end of the array, since the first element was already accounted
for. The fix is to add the stride times the reps minus 1.