[Yang model] Allow user to set none value for interface type #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
approved these changes
Oct 27, 2021
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Aug 17, 2022
swss: * 665bbbb 2022-06-27 | Add support for IP interface loopback action (sonic-net#2307) (HEAD -> 202205, github/202205) [Lior Avramov] * c7f5743 2022-06-28 | [asan] suppress the static variable leaks (sonic-net#2354) [Yakiv Huryk] * 37e2a31 2022-06-28 | [tests] [asan] add graceful stop flag (sonic-net#2347) [Yakiv Huryk] * 5ab84cf 2022-06-28 | [202205][cherry-pick] Fix mux_acl_rule adding issue (sonic-net#2358) [bingwang-ms] linkmgrd: * a836ef7 2022-06-28 | Use Vlan MAC as src MAC for link prober by default (#93) (HEAD -> 202205) [Jing Zhang] * a828e86 2022-06-28 | Fix inconsistent mux state (#92) (github/202205) [Longxiang Lyu] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Feb 1, 2023
a1830c1761087bdc1f7433ebbb8d0bdc419da0d3 (HEAD -> 201911, origin/master, origin/HEAD, origin/201911) Fix OpenAPI spec to be readable by autorest (#101) 94805a39ac0712219f7dc08faa2cfdbf371dd177 Identify and report Vnet GUID for conflicting VNI (#99) 4832dfd677de72edc44d4eb8c1b60cfad79a3355 Static route expiry if not specified as persistent (#98) 5cc4358fb67b9e2a0da9a6691064e41f97ebebc2 (master) Add support for overlay ECMP (#96) 6822a46197daef060b4d00dba5153b04b163c43f [CI] Set diff cover threshold to 50% (#97) dcc826a1503060b9a07e4510b4f48331c49e87dd Add PR diff coverage (#95) e842c5ff317c67919dcbcab3358143cb9a16c9dd Generate code coverage for Unit Tests (#94) f9bbed3cb86a3bab9a07745096835dbdbe5a4db6 Convert Unit Tests from unittest framework to pytest framework (#93) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Oct 24, 2024
…utomatically (sonic-net#20217) #### Why I did it src/sonic-host-services ``` * dbb063a - (HEAD -> 202405, origin/202405) [BFD]Fix BFD blackout issue (#150) (52 minutes ago) [Sudharsan Dhamal Gopalarathnam] * 8b3fcbe - Password Hardening: Add support to disable expiration date (#93) (52 minutes ago) [davidpil2002] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Dec 11, 2024
…utomatically (sonic-net#20022) #### Why I did it src/sonic-host-services ``` * e21db16 - (HEAD -> master, origin/master, origin/HEAD) [BFD]Fix BFD blackout issue (#150) (26 hours ago) [Sudharsan Dhamal Gopalarathnam] * 39834f2 - Password Hardening: Add support to disable expiration date (#93) (4 days ago) [davidpil2002] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Allow user to set none value for interface type
Why I did it
Say user has speed=50G, interface_type=CR2, and user wants to change it to 10G and CR. Currently, there is no CLI can support it, because:
The only way for now is to manually change the CONFIG_DB and do a config reload, this is not user friendly.
This PR allow user to set none value to interface type. So there is a way to achieve the goal via CLI:
How I verified it
Manual test
Details if related