Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added browser tests. Firefox, Chrome, PhantomJS, Safari, Internet Explorer #74

Merged
merged 4 commits into from
Nov 3, 2017
Merged

Added browser tests. Firefox, Chrome, PhantomJS, Safari, Internet Explorer #74

merged 4 commits into from
Nov 3, 2017

Conversation

hustf
Copy link
Collaborator

@hustf hustf commented Nov 2, 2017

modified: travis.yml               excluded 0.7 (httpcommon fails) , included 0.6. httpcommon. 0.6 included.
modified:   appveyor.yml                 Installs chrome, firefox. Precompiles httpserver with no depwarns.
new file:   test/REQUIRE                 0.5 minimum for testing. Still 0.4 for use.
modified:   test/runtests.jl			 Includes browsertest.jl
new file:   test/favicon.ico             Tab icon for non-headless browsers.
new file:   test/browsertest.html        Web page with three websockets: General, subprotocol and bad protocol.
new file:   test/browsertest.jl          < runtests.jl. Launches up to five browsers. Tests websockets on the browsers which requests browsertest.
new file:   test/functions_open_browsers.jl   < browsertest. Launches available browsers on localhost browsertest (not tested on unix / linux).
new file:   test/phantom.js                     < functions_open_browsers. Shell script for the browser with closedown on timeout, also sets the user-agent.
new file:   test/functions_server.jl     < browsertest. A server with websockets and logging.
new file:   test/functions_log_test.jl                             < functions_server. Blocking console logs, colorful output for servers & etc.
new file:   test/handler_functions_events.jl                       < functions_server. Logs fired events to console.
new file:   test/handler_functions_websockets_general_test.jl      < functions_server. Stores ws messages and sends replies.
new file:   test/handler_functions_websockets_subprotocol_test.jl  < functions_server. Store ws messages and replies.

…cluded.

modified:   appveyor.yml                 Installs chrome, firefox. Precompiles httpserver with no depwarns.
new file:   test/REQUIRE                 0.5 minimum for testing. Still 0.4 for use.
modified:   test/runtests.jl			 Includes browsertest.jl
new file:   test/favicon.ico             Tab icon for non-headless browsers.
new file:   test/browsertest.html        Web page with three websockets: General, subprotocol and bad protocol.
new file:   test/browsertest.jl          < runtests.jl. Launches up to five browsers. Tests websockets on the browsers which requests browsertest.
new file:   test/functions_open_browsers.jl   < browsertest. Launches available browsers on localhost browsertest (not tested on unix / linux).
new file:   test/phantom.js                     < functions_open_browsers. Shell script for the browser with closedown on timeout, also sets the user-agent.
new file:   test/functions_server.jl     < browsertest. A server with websockets and logging.
new file:   test/functions_log_test.jl                             < functions_server. Blocking console logs, colorful output for servers & etc.
new file:   test/handler_functions_events.jl                       < functions_server. Logs fired events to console.
new file:   test/handler_functions_websockets_general_test.jl      < functions_server. Stores ws messages and sends replies.
new file:   test/handler_functions_websockets_subprotocol_test.jl  < functions_server. Store ws messages and replies.
@hustf
Copy link
Collaborator Author

hustf commented Nov 2, 2017

This is a rewrite of PR 73 (closed). Mainly changed os x behaviour.

hustf added 2 commits November 2, 2017 21:02
modified:   test/phantom.js       Increased time to close for phantomjs to 20 s. 10 s not sufficient on travis.
modified:   test/functions_server.jl          Changed color symbols for 0.5
modified:   test/handler_functions_events.jl      Changed color symbols for 0.5
modified:   test/handler_functions_websockets_general_test.jl  Changed color symbols for 0.5
modified:   test/handler_functions_websockets_subprotocol_test.jl Changed color symbols for 0.5
modified:   test/phantom.js       Increase timeout to 20 s for travis linux.
@coveralls
Copy link

Coverage Status

Coverage increased (+28.01%) to 78.014% when pulling fce40cd on hustf:addBrowseTest2 into 78987bd on JuliaWeb:master.

@coveralls
Copy link

coveralls commented Nov 2, 2017

Coverage Status

Coverage increased (+28.2%) to 78.169% when pulling 4cfbf67 on hustf:addBrowseTest2 into 78987bd on JuliaWeb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+28.9%) to 78.873% when pulling fce40cd on hustf:addBrowseTest2 into 78987bd on JuliaWeb:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+28.9%) to 78.873% when pulling fce40cd on hustf:addBrowseTest2 into 78987bd on JuliaWeb:master.

@coveralls
Copy link

coveralls commented Nov 2, 2017

Coverage Status

Coverage increased (+28.9%) to 78.873% when pulling fce40cd on hustf:addBrowseTest2 into 78987bd on JuliaWeb:master.

@coveralls
Copy link

coveralls commented Nov 2, 2017

Coverage Status

Coverage increased (+28.9%) to 78.873% when pulling 4cfbf67 on hustf:addBrowseTest2 into 78987bd on JuliaWeb:master.

@hustf
Copy link
Collaborator Author

hustf commented Nov 3, 2017

Studying the logs from tests reveal some issues with HttpCommon and HttpServer.

Closes #52 (actually in 0.2.3.)
Closes #29 (actually in 0.2.3.)
Closes #28 (logging is only added for testing, but this can easily be adapted for projects)
Closes #22 (actually in 0.2.3)
Closes #21

@hustf
Copy link
Collaborator Author

hustf commented Nov 3, 2017

Closes #52 (actually in 0.2.3.)
Closes #29 (actually in 0.2.3.)
Closes #28 (logging is only added for testing, but this can easily be adapted for projects)
Closes #22 (actually in 0.2.3)
Closes #21

@hustf hustf merged commit e1f094c into JuliaWeb:master Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants