Add browser tests: Chrome, IE11, Firefox, Safari PhantomJS #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified .travis.yml: Drop 0.4, add 0.6, install firefox latest
modified appveyor.yml: Compile HttpServer before adding WebSockets to
remove warnings from other packages. Tested coveralls
submittal (not included, was 73%).
new file test/browsertest.html Page for all browsers with javascript and three test websockets.
new file test/browsertest.jl Opens available browsers. For those that respond on the test system,
test handshakes, text communication, closing from both ends.
new file test/server_functions.jl httpserver, websocket distributor.
new file test/event_functions.jl Event functions for server_functions, httpserver
new file test/favicon.ico A Julia icon for opened browser tabs.
new file test/handler_functions_websockets_general_test.jl
Multi-instance functions for reading one websocket each.
new file test/handler_functions_websockets_subprotocol_test.jl
Multi-instance functions for reading one websocket each.
new file test/log_functions_test.jl Colorful console feedback with locked writes.
new file test/open_unix_os_browsers.jl For spawning browsers on travis
new file test/open_windows_browsers.jl For spawning browsers on appveyor
modified test/runtests.jl Added one line at the end.
|
This is nice! Feel free to hit the merge button @hustf ! This package uses 4 space indentation, I see you use tabs. I'd say this is not a big deal as long as we don't mix both in the same file. Cheers 🎉 |
|
Thanks Shashi, but I want it to work on unix osx first. Dont have any of those where I am. In the meantime, can you tag the current state? I dont have a full name user. |
|
Due to file name changes while getting this to work on osx, I think the revision history will be clearer by not accepting this PR. Will make a new PR shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorely needed tests, ref. issue #21, #52. Also an attempt to address logging, issue #28, reasons for closing, issue #29. To limit the scope, binary data tests #18 are not included in this PR.
Sorely needed input regarding spawning browsers on osx / linux. For windows, setting the command line switches so as to not restore old sessions and cause confusion took some experimenting.
Also, if someone with admin access to this repository can provide a coveralls repo token encrypted by appveyor, we can add coverage from windows tests. Coverage is on 73% now, on appveyor.