Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup prior to tag #184

Merged
merged 5 commits into from
Nov 29, 2022
Merged

Cleanup prior to tag #184

merged 5 commits into from
Nov 29, 2022

Conversation

hustf
Copy link
Collaborator

@hustf hustf commented Nov 28, 2022

Initial commit - timeout tests running OK locally.

modified: benchmark/functions_open_browsers.jl Chrome path, i……s_xxx() syntax
modified: test/timeout/limited life websockets.html 9ws, max 256s timeout
modified: test/timeout/timeout.jl Fewer websockets, Julia update

TODO: Readme, etc.
These changes are not included continuous integration tests.

…syntax

modified:   test/timeout/limited life websockets.html  9ws, max 256s timeout
modified:   test/timeout/timeout.jl                    Fewer websockets, Julia update
modified:   Project.toml         julia = "1.8.2"
modified:   README.md            Upgrade section, intention
modified:   REQUIRE              Same req. as Project.toml
modified:   test/client_test.jl  Response(101, "http must have text")
modified:   test/error_test.jl   Response(200, "OK")
modified:   test/show_test.jl    Response(200, "OK")
@hustf
Copy link
Collaborator Author

hustf commented Nov 29, 2022

Response(200) is no longer an acceptable return from a http handler. Rather, Response(200, "OK"), works. In other contexts, Response(101) is acceptable, while Response(101, "message") is not OK. This seems likely to change in future HTTP versions.

modified:   appveyor.yml   Drop   - julia_version: 1.6.3, 1.8.3 -> 1.8.2
modified:   src/Logger/websocketlogger.jl
modified:   test/error_test.jl
modified:   test/test_websocketlogger.jl
@hustf hustf merged commit 811d94b into master Nov 29, 2022
@hustf hustf deleted the cleanup182 branch November 29, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant