-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HTTP.jl compat entry #164
Conversation
doesn't seem to cause any new test failures locally |
Let's try this out in master. There's so much going on in HTTP.jl. |
Before we merge, could you make the change in test/Project.toml too ? You may have 'git fetch upstream' first. |
Oh I hadn't noticed this file was there. |
Okay that was just done now in an other PR. I didn't realize the |
bump, this is holding back HTTP for everyone who (still) uses Atom |
e.g. here JunoLab/Atom.jl#359 |
Pending PR #165. |
No need to rebase, I think? |
to prevent holding back other packages
tests pass locally on 1.0.5 and 1.5.2 so I expect this to work |
✅ |
For info: Waiting for a manual merge here: |
The test linked from README.md failed due to a download error. Updated Readme.md to trigger a rerun (a private run using my private account was successful. Will probably look at this again tomorrow. Now I'm not sure if posting a comment is going to update both the version number in the Project file and the git version number. I haven't been using the new systems before, so if you are more updated, please tell! |
You should make a commit to update the version in Maybe you need to install the github app, and then it works like this: |
The git tag will be updated by tagbot which appears to be working well. |
Thank you, jebej! For the advice, and for the original commit.! |
to prevent holding back other packages