Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTTP.jl compat entry #164

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Update HTTP.jl compat entry #164

merged 1 commit into from
Dec 17, 2020

Conversation

jebej
Copy link
Contributor

@jebej jebej commented Dec 10, 2020

to prevent holding back other packages

@jebej
Copy link
Contributor Author

jebej commented Dec 10, 2020

doesn't seem to cause any new test failures locally

@hustf
Copy link
Collaborator

hustf commented Dec 10, 2020

Let's try this out in master. There's so much going on in HTTP.jl.

@hustf
Copy link
Collaborator

hustf commented Dec 10, 2020

Before we merge, could you make the change in test/Project.toml too ? You may have 'git fetch upstream' first.

@jebej
Copy link
Contributor Author

jebej commented Dec 10, 2020

Oh I hadn't noticed this file was there.
Would it be okay if I just add the test dependencies to the main project file, as is normally done and remove the file in test?
e.g. here: https://github.com/JuliaWeb/HTTP.jl/blob/master/Project.toml

@jebej
Copy link
Contributor Author

jebej commented Dec 10, 2020

Okay that was just done now in an other PR.

I didn't realize the test/Project.toml file setup was the future (tm), but I'd suggest that since the old-style setup with test dependencies in the main Project file is not going away anytime soon that we just stick to the one main file for now (to avoid duplication).

@jebej
Copy link
Contributor Author

jebej commented Dec 12, 2020

bump, this is holding back HTTP for everyone who (still) uses Atom

@jebej
Copy link
Contributor Author

jebej commented Dec 12, 2020

e.g. here JunoLab/Atom.jl#359

@hustf
Copy link
Collaborator

hustf commented Dec 12, 2020

Pending PR #165.

@hustf
Copy link
Collaborator

hustf commented Dec 12, 2020

No need to rebase, I think?

to prevent holding back other packages
@jebej
Copy link
Contributor Author

jebej commented Dec 12, 2020

tests pass locally on 1.0.5 and 1.5.2 so I expect this to work

@jebej
Copy link
Contributor Author

jebej commented Dec 13, 2020

@hustf
Copy link
Collaborator

hustf commented Dec 14, 2020

For info: Waiting for a manual merge here:
JuliaRegistries/General#26310

@hustf hustf merged commit 4cf9ac4 into JuliaWeb:master Dec 17, 2020
@jebej jebej deleted the patch-1 branch December 17, 2020 19:48
@hustf
Copy link
Collaborator

hustf commented Dec 17, 2020

The test linked from README.md failed due to a download error. Updated Readme.md to trigger a rerun (a private run using my private account was successful. Will probably look at this again tomorrow.

Now I'm not sure if posting a comment is going to update both the version number in the Project file and the git version number. I haven't been using the new systems before, so if you are more updated, please tell!

@jebej
Copy link
Contributor Author

jebej commented Dec 17, 2020

You should make a commit to update the version in Project.toml, and then comment on that commit for Registrator, no?

Maybe you need to install the github app, and then it works like this:
JuliaNLSolvers/Optim.jl@0b53f05

@jebej
Copy link
Contributor Author

jebej commented Dec 17, 2020

The git tag will be updated by tagbot which appears to be working well.

@hustf
Copy link
Collaborator

hustf commented Dec 18, 2020

Thank you, jebej! For the advice, and for the original commit.!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants