Support for reading tzfiles #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before read_tzfile would always convert from big-endian (network byte order / "standard byte order") to little-endian. Now the code will convert from big-endian to the endianness of the host.
- Naming now is closer to Olson.resolve! - Removed unneeded variables - Updated reference to IANA which includes details on version 3
|
We should add support for version 2 and version 3 before this gets merged. Here is a example of a version 2 tzfile for Warsaw. |
Also fixed a bug where read_tzfile_internal was returning a
FixedTimeZone in some cases and a Array{Transition} in another.
The initial transition DateTime can sometimes be a value that is suppose to represent negative infinity. When this happens we should use the typemin(DateTime). As part of this change I also introduced tests for the first and last transition dates for all tzfile tests.
f1c6fe4 to
10cbad1
Compare
|
Seems to be something up with 32-bit support. Looking into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for parsing a TimeZone from a tzfile