Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If file does not exist, create it (No Prompt) #52

Merged
merged 3 commits into from
Feb 18, 2020
Merged

Conversation

oxinabox
Copy link
Member

This removes the prompt before creating reference files.

I have wanted this for a while, because when creating dozens (or hundreds) of reference files, I don't want to sit there hammering "yes".
This also means if I need to regenerate everything, I can delete my reference folder and rerun my tests.

I tend to do almost all my review of reference files during code-review rather than in the terminal.

I think this is a better behavour, but In theory someone could be relying on this to make sure that files were not created by mistake, e.g. by looking at the filename, not just the content.

So I bumped this as a breaking change, just incase.
Its not really an API change, as much as a UI change.
Maybe I should only do a nonbreaking verion bump?

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this change also makes some test cases possible in CI environment.

Perhaps we can make similar changes for reference updates but raise a @warn instead of @info (Oh no we can't because this would break the test pipeline and gives a fake green check even if some reference doesn't match.)

src/test_reference.jl Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 18, 2020

Coverage Status

Coverage increased (+4.2%) to 89.516% when pulling 6791818 on ox/noprompttocreate into ffbfb29 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants