Some small changes to avoid access to properties of Cholesky objects #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindahua
added a commit
that referenced
this pull request
Aug 17, 2014
Some small changes to avoid access to properties of Cholesky objects
|
Thanks! |
|
You are welcome. After all, I broke it. How do you usually handle versioning and dependent packages in a situation like this? Is |
|
I think we should tag this as next minor version (instead of patch). I guess this version only works on master but not on 0.3? |
|
No, I just tried it with 0.3 and it works fine. The reason is that the new code doesn't touch the properties, but uses |
|
If it works for 0.3 then we can tag it as a patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes to the
Choleskyimmutable in Base brokeunwhiten. This pull request fixes this.