Remove eigmin and eigmax definitions for PDSparseMat and thereby #115
+10
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've now also enabled testing on the latest Julia release and dropped support for Julia 0.7 to avoid increasing the number of tested versions. |
ararslan
reviewed
May 14, 2020
| @@ -50,9 +48,6 @@ end | |||
|
|
|||
| Base.inv(a::PDSparseMat{T}) where {T<:Real} = PDMat( a\eye(T,a.dim) ) | |||
| LinearAlgebra.logdet(a::PDSparseMat) = logdet(a.chol) | |||
| LinearAlgebra.eigmax(a::PDSparseMat{T}) where {T<:Real} = convert(T,eigs(convert(SparseMatrixCSC{Float64,Int},a.mat), which=:LM, nev=1, ritzvec=false)[1][1]) #to avoid type instability issues in eigs, see e.g., julia issue #13929 | |||
There was a problem hiding this comment.
Are there fallback definitions somewhere that will produce the right thing for a PDSparseMat?
There was a problem hiding this comment.
No. The PR is removing functionality based on a trade off between how useful this method is (I don’t think it is) and how costly it is to have the binary dependency for all downstream packages
There was a problem hiding this comment.
Okay. I don't have an opinion here so I trust your judgement on this as long as we make this a breaking release.
ararslan
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stop depending on Arpack. The Arpack dependency sometimes causes some problems on some platforms and since Distributions depend on PDMats it means that most users end up depending on Arpack even though they never compute
eigmaxoreigminof a sparse matrix even indirectly.